-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix private code imported from SW lib #291
Comments
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. |
Ping |
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. |
Pong |
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. |
. |
@gaetbout A better way to implement this that I can think about is using bitwise left shift directly instead of match statement with hardcoded values for each shift. also directly using the operator will allow us to handle any shift amount (up to max allowed by the type ofc) which would be better than total 31 bytes that we are handling using match. But I think But I don't find anything inherently wrong with this standard implementation itself. Sorry if the question is dumb, new to Starknet and Cairo in general! Thanks |
My point is that we shouldn't have function copy pasted from SW repo. |
If SW can make the methods public, that would be sweet! |
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. |
Ping |
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. |
pong |
// TODO Remove all done, it was copied from Starkware's library. There must be a better way
Fix this todo.
The text was updated successfully, but these errors were encountered: