Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the repo to latest edition #290

Merged
merged 45 commits into from
Apr 12, 2024
Merged

Updating the repo to latest edition #290

merged 45 commits into from
Apr 12, 2024

Conversation

gaetbout
Copy link
Contributor

@gaetbout gaetbout commented Apr 2, 2024 •
edited
Loading

STILL DRAFT WORKING ON IT

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

This PR updates the repository to use the latest edition.
This might have some breaking changes as some struct/fn/enums might now not be public by default but if any, it should be easy to identify and fix.
BREAKING some data serialization

@gaetbout gaetbout marked this pull request as ready for review April 5, 2024 13:17
@gaetbout gaetbout requested a review from LucasLvy as a code owner April 5, 2024 13:17
@gaetbout
Copy link
Contributor Author

gaetbout commented Apr 5, 2024

@LucasLvy HF

LucasLvy
LucasLvy requested changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@LucasLvy LucasLvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jte hais

src/bytes/src/bytes.cairo Outdated Show resolved Hide resolved
src/bytes/src/bytes.cairo Outdated Show resolved Hide resolved
src/bytes/src/bytes.cairo Outdated Show resolved Hide resolved
src/bytes/src/tests/test_bytes.cairo Show resolved Hide resolved
src/bytes/src/utils.cairo Outdated Show resolved Hide resolved
src/sorting/src/tests/merge_sort_test.cairo Outdated Show resolved Hide resolved
src/sorting/src/tests/merge_sort_test.cairo Outdated Show resolved Hide resolved
src/sorting/src/tests/merge_sort_test.cairo Outdated Show resolved Hide resolved
src/sorting/src/tests/merge_sort_test.cairo Outdated Show resolved Hide resolved
src/storage/src/list.cairo Outdated Show resolved Hide resolved
@gaetbout
Copy link
Contributor Author

gaetbout commented Apr 5, 2024

Addressed some comments, will continue later :)

@gaetbout
Copy link
Contributor Author

@LucasLvy trying to fix all those reaming struct pub fields but running in a lot of issues...
Could we maybe ignore those for the moment and I'll make a separate PR for each one?

@LucasLvy
Copy link
Collaborator

i'd rather not, it's part of the migration, maybe use https://stacking.dev/?

@gaetbout
Copy link
Contributor Author

@LucasLvy Ready for round 2

LucasLvy
LucasLvy requested changes Apr 12, 2024
View reviewed changes
src/math/src/fast_power.cairo Outdated Show resolved Hide resolved
src/math/src/i257.cairo Outdated Show resolved Hide resolved
@LucasLvy LucasLvy merged commit d175c45 into keep-starknet-strange:main Apr 12, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LucasLvy LucasLvy LucasLvy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaetbout @LucasLvy