Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: replace md5 #1348

Closed
tdelabro opened this issue Jan 5, 2024 · 5 comments · Fixed by #1366
Closed

dev: replace md5 #1348

tdelabro opened this issue Jan 5, 2024 · 5 comments · Fixed by #1366
Assignees
@fishseabowl
Labels
backlog Ready to be picked enhancement New feature or request

Comments

@tdelabro
Copy link
Collaborator

tdelabro commented Jan 5, 2024

We use md5 to make sure of our genesis-assets integrity.
But this hashing function had been broken in the past. Maybe we should replace it with something more solid
@tdelabro tdelabro added enhancement New feature or request backlog Ready to be picked labels Jan 5, 2024
@fishseabowl
Copy link
Contributor

Which is better: SHA-3 or BLAKE2? Thanks!

@tdelabro
Copy link
Collaborator Author

tdelabro commented Jan 8, 2024

@LucasLvy do you have a recomendation here?

@LucasLvy
Copy link
Contributor

LucasLvy commented Jan 8, 2024

sha3

@tdelabro
Copy link
Collaborator Author

tdelabro commented Jan 8, 2024

@fishseabowl you want to work on this?

@fishseabowl
Copy link
Contributor

@tdelabro Yes. Thanks!

@fishseabowl fishseabowl mentioned this issue Jan 12, 2024
Merged
tdelabro pushed a commit that referenced this issue Jan 15, 2024
@fishseabowl
feat: replace md5 with sha_256 hash function #1348 (#1366)
fd064e1 
Co-authored-by: fishseabowl <xuefei.han@domichain.io>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fishseabowl fishseabowl

Labels
backlog Ready to be picked enhancement New feature or request
Projects
Madara
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace md5 with sha_256 hash function #1348 fishseabowl/madara
3 participants
@fishseabowl @tdelabro @LucasLvy