-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug:Retrieving class for contract version 0 reported an error #1585
Comments
This test is currently ignored: https://github.com/keep-starknet-strange/madara/blob/38ef50e00a7c53ef55b5b2eb9a9f59426738de03/starknet-rpc-test/get_class_at.rs#L47C13-L47C20 Which is the purpose of your PR #1523. This issue seems to say that the test is failing at a commit that does not contain your PR changes. Does it still fail on your #1523 branch? |
@fishseabowl can you list the next steps please? What to merge now? What to fix later? |
@tdelabro The PR #1523 is ready to be merged. After that, we'll look into why ContractClass::Legacy serde_json format isn't decoding correctly in this issue #1585 and fix it. Thanks |
#1523 has been merged |
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. |
I changing a lot of stuffs related to this here: #1631 |
Bug Report
Madara version:
commit: 38ef50e
Current behavior:
In the file starknet-rpc-test/get_class_at.rs, line 67:
reported: Error: invalid type: map, expected string at line 1 column 134
Expected behavior:
No error reported
Steps to reproduce:
Run work_ok_retrieving_class_for_contract_version_0 unit test
Related code:
Other information:
The text was updated successfully, but these errors were encountered: