Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove global state root #1039

Merged

Conversation

apoorvsadana
Copy link
Collaborator

Removing global state root in the runtime as it wasn't working very well with the chain. It will be added later to the client side similar to how Starknet does it

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 2.77% and project coverage change: -0.81% ⚠️

Comparison is base (6918bf2) 43.43% compared to head (5672054) 42.63%.
Report is 1 commits behind head on main.

❗ Current head 5672054 differs from pull request most recent head 4cb2042. Consider uploading reports for the commit 4cb2042 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
- Coverage   43.43%   42.63%   -0.81%     
==========================================
  Files          88       87       -1     
  Lines       10845    10582     -263     
  Branches    10845    10582     -263     
==========================================
- Hits         4711     4512     -199     
+ Misses       5602     5561      -41     
+ Partials      532      509      -23     
Files Changed Coverage Δ
crates/client/rpc-core/src/lib.rs 33.33% <ø> (ø)
crates/client/rpc/src/lib.rs 0.16% <ø> (+0.01%) ⬆️
crates/client/storage/src/overrides/mod.rs 0.00% <ø> (ø)
...client/storage/src/overrides/schema_v1_override.rs 0.00% <ø> (ø)
crates/node/src/command.rs 0.00% <0.00%> (ø)
...s/pallets/starknet/src/blockifier_state_adapter.rs 78.37% <ø> (+15.55%) ⬆️
crates/pallets/starknet/src/runtime_api.rs 0.00% <ø> (ø)
crates/pallets/starknet/src/types.rs 0.00% <ø> (ø)
crates/primitives/starknet/src/storage/mod.rs 0.00% <ø> (ø)
crates/runtime/src/lib.rs 16.32% <ø> (+0.56%) ⬆️
... and 2 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tdelabro tdelabro merged commit 1729adc into keep-starknet-strange:main Aug 24, 2023
11 of 12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants