feat(rpc): Added starknet_getTransactionStatus and removed starknet_pendingTransactions #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdelabro
requested changes
Dec 6, 2023
tdelabro
requested changes
Dec 6, 2023
tdelabro
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(rpc): Added starknet_getTransactionStatus and removed starknet_pendingTransactions
This PR solves the implementation of a new call: starknet_getTransactionStatus and the removal of starknet_pendingTransactions according to the v0.5.1 RPC specs described in #1291
starknet_getTransactionStatusGets the Transaction Status, Including Mempool Status and Execution Details
This method retrieves the status of a specified transaction. It provides information on
whether the transaction is still in the mempool, has been executed, or dropped from the
mempool. The status includes both finality status and execution status of the
transaction.
Arguments
transaction_hash- The hash of the transaction for which the status is requested.Returns
transaction_status- An object containing the transaction status details:finality_status: The finality status of the transaction, indicating whether it isconfirmed, pending, or rejected.
execution_status: The execution status of the transaction, providing details on theexecution outcome if the transaction has been processed.
Expected behavior
Notes