test: Improve tests of exchange_router contract.
#555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaeljy
commented
Oct 27, 2023
| @@ -288,13 +288,13 @@ mod ExchangeRouter { | |||
|
|
|||
| fn create_deposit(ref self: ContractState, params: CreateDepositParams) -> felt252 { | |||
| let data_store = self.data_store.read(); | |||
| global_reentrancy_guard::non_reentrant_before(data_store); | |||
| // global_reentrancy_guard::non_reentrant_before(data_store); | |||
There was a problem hiding this comment.
The global_reentrancy_guard::non_reentrant_before function is also called in the create_deposit function.
So I think there's one call too many, please, can you check if it's really this call that should be removed and not the one from the create_deposit function?
khaeljy
commented
Nov 13, 2023
|
|
||
| key | ||
| } | ||
|
|
||
| fn cancel_deposit(ref self: ContractState, key: felt252) { | ||
| let data_store = self.data_store.read(); | ||
| global_reentrancy_guard::non_reentrant_before(data_store); | ||
| // global_reentrancy_guard::non_reentrant_before(data_store); |
There was a problem hiding this comment.
The global_reentrancy_guard::non_reentrant_before function is also called in the cancel_deposit function.
So I think there's one call too many, please, can you check if it's really this call that should be removed and not the one from the cancel_deposit function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #544
What is the new behavior?
Does this introduce a breaking change?
NO
Other information