Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean memecoin tests and impl #112

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Dec 31, 2023

  • use constant values for deployment test addresses
  • use constant values for deployment variables
  • clean deployment utils
  • clean tests to use reusable deployment logic
  • add ownership entrypoints to memecoin
  • add entrypoints to get locker and factory addresses

This should be merged after #105 as it depends on it (and once 105 is merged, the base branch should be changed to main)

Copy link

vercel bot commented Dec 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unruggable-memecoin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2024 3:34pm

@enitrat enitrat changed the base branch from refactor/clean-memecoin-impl to main January 1, 2024 15:28
feat: make transfer_limit_delay a parameter
feat: PercentageMath library

refactor: clean erc20 entrypoints tests

refactor: clean erc20 entrypoints tests

refactor: clean memecoin tests
Copy link
Contributor

@0xEniotna 0xEniotna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@enitrat enitrat merged commit d108bcc into main Jan 1, 2024
6 checks passed
enitrat added a commit that referenced this pull request Jan 1, 2024
@0xChqrles 0xChqrles deleted the refactor/clean-memecoin-tests branch April 23, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants