Eth/ERC20 Bridge related contracts #9
Conversation
|
Requirement for #1419 |
* feat : added ethereum client for custom input * feat : code refactoring | module splitting * fixes : pr #1 * fixes : pr #1 | iter 2 * fixes : pr #1 | proxy client update * fixes : pr #1 | proxy client update | ethereum instance * fixes : pr #1 | proxy client update | ethereum instance * fix : starkgate_manager_client modules * feat : updated the deps and visibility * feat : updated abis
|
|
||
| use utils::errors::Error; | ||
|
|
||
| type Address = H160; |
There was a problem hiding this comment.
Tbh I'd remove these aliases, they do not contribute much to the readability (on the contrary you have to check what's the actual type).
There was a problem hiding this comment.
But isn't Address more readable than H160?
.idea/.gitignore
Outdated
There was a problem hiding this comment.
let's add this to gitignore
|
|
||
| use utils::errors::Error; | ||
|
|
||
| type Address = H160; |
There was a problem hiding this comment.
But isn't Address more readable than H160?
|
I have pushed some of the changes. I will add the contract changes also and push |
|
@apoorvsadana @EvolveArt @unstark I have pushed the changes requested. For the Proxy part, I am creating a new issue as a few things were breaking while testing. Please review the latest changes and please do tell me if anything needs to be changed. |
crates/ethereum-instance/src/lib.rs
Outdated
| /// Will try to attach to already running Anvil instance or custom rpc and private key provided to the function. | ||
| /// if not provided any argument it will attack to a default anvil instance with default anvil params. | ||
| pub fn attach(rpc_endpoint: Option<String>, priv_key: Option<String>) -> Result<Self, Error> { | ||
| let rpc_endpoint = rpc_endpoint.unwrap_or_else(|| { | ||
| std::env::var("ANVIL_ENDPOINT") |
There was a problem hiding this comment.
let's rename this as well to make it generic, ETH_RPC_ENDPOINT? we will also need to change it in Madara
* Legacy Bridge (Eth) solidity contracts were downloaded from etherscan as the function selector required for eth
deposit was not present in any of the branch of starkgate-contracts. Cairo contract was taken from branch
update-cairo- 0.9.0of starkgate-contracts.* Token Bridge (ERC20) contracts were fetched from starkgate-contracts release v2.0