Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#519 improve set integration bench #527

Merged

Conversation

StringNick
Copy link
Collaborator

close #519
after this changes:

Time (mean ± σ):     423.0 ms ±   2.2 ms    [User: 386.1 ms, System: 31.1 ms]
  Range (min … max):   421.2 ms … 428.8 ms    10 runs

@StringNick StringNick changed the title #519 improve set integration bench Draft: #519 improve set integration bench Jun 19, 2024
@StringNick StringNick marked this pull request as draft June 19, 2024 19:40
@StringNick
Copy link
Collaborator Author

pushed improved perfomance bech:

Time (mean ± σ):     268.8 ms ±   2.3 ms    [User: 227.5 ms, System: 31.4 ms]
  Range (min … max):   266.2 ms … 272.7 ms    10 runs

1.9x perfomance increased overall bench

@StringNick StringNick changed the title Draft: #519 improve set integration bench #519 improve set integration bench Jun 19, 2024
@StringNick StringNick self-assigned this Jun 19, 2024
@StringNick StringNick marked this pull request as ready for review June 19, 2024 20:32
Copy link
Contributor

@lana-shanghai lana-shanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lana-shanghai lana-shanghai merged commit 36e27d5 into keep-starknet-strange:main Jul 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf: Try to improve set_integration_benchmark.cairo
2 participants