Skip to content
This repository has been archived by the owner on Dec 9, 2021. It is now read-only.

Qt5 support #81

Closed
wants to merge 12 commits into from
Closed

Qt5 support #81

wants to merge 12 commits into from

Conversation

mathstuf
Copy link
Contributor


See #17 for the original submission. #70 is also asking for this.

@metasystem
Copy link

is qt5 fully supported now?

@mathstuf
Copy link
Contributor Author

This branch built against it, but I may have missed something.

@m-kuhn
Copy link

m-kuhn commented Mar 30, 2015

It may be nice to use automoc instead of having all the conditional wrap_cpp directives in cmake.

Introduced in 2.8.6.
@mathstuf
Copy link
Contributor Author

mathstuf commented Apr 2, 2015

Automoc done.

@mathstuf
Copy link
Contributor Author

mathstuf commented Apr 2, 2015

Automoc requires 2.8.6 as the minimum CMake version, but this only really rules out Debian oldstable (though available in backports) and RHEL5.

@metasystem
Copy link

Are y ou sur users from debian oldstable & rehl5 use keepassx or keepass? This config will ne more présent on full tty or ssh server nom? And are they use qt5?

@mathstuf
Copy link
Contributor Author

mathstuf commented Apr 2, 2015

Sorry, I was informing of where 2.8.6 is not available without compiling from source. The minimum version is bumped with Qt4 as well since it has automoc support too (and the idea was to remove conditionals). 2.8.6 was released in October 2011 or so.

@mathstuf
Copy link
Contributor Author

mathstuf commented Apr 8, 2015

Eh, seems the $<TARGET_FILE:> thing isn't working right? I'll look into it tonight.

@mathstuf
Copy link
Contributor Author

mathstuf commented Apr 9, 2015

Updated the branch with the fix for testing. Should be good to go (I also verified that Qt4 still builds and tests as well) if you're fine with it.

@metasystem
Copy link

Still have some bug. We don't have global auto-type keyword set on qt5. So I have it on 2.0 alpha 6 qt4 version. Is it normal? I can't perform auto-type on funtoo current/i3-WM ...

@mathstuf
Copy link
Contributor Author

mathstuf commented Apr 9, 2015

Hmm. I've never tried the autotype stuff. I'll try poking it tonight.

@mathstuf
Copy link
Contributor Author

mathstuf commented Apr 9, 2015

I can't get auto-type to work at all on master or at any point back to where it was added for 2.x. It does work for 0.4.3 though.

@euroelessar
Copy link

Any progress there?

@debfx, may you have a look here? What concerns do you have about the patch, may be I'm able to improve it to have it merged?

@mathstuf
Copy link
Contributor Author

I'm unfamiliar with autotype, but it looks like moving it to 2.x is what broke it based on my testing (but I'm also on XMonad without EMWH support, so who knows). If someone else can get it to work on master and not here, that'd be new info to me.

@debfx
Copy link
Member

debfx commented Jul 22, 2015

I have pushed experimental Qt 5 support to the qt5 branch.

@debfx debfx closed this Jul 22, 2015
@m-kuhn
Copy link

m-kuhn commented Jul 23, 2015

Qt 5 branch compiles and runs fine on Fedora 22 (64bit)
All tests pass

@xf-
Copy link

xf- commented Jul 23, 2015

qt5 branch compiles and runs fine on arch 64bit.
Is now in git AUR package default branch.

@ArchangeGabriel
Copy link

@debfx: Any ETA regarding the 2.1 release with QT5 onboard? This is the last QT4 package left on my system, it would be so cool to be able to definitively get ride of it. ;)

daniellandau pushed a commit to daniellandau/keepassx that referenced this pull request Feb 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
7 participants