Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout or not connected to KeePassXC #130

Closed
bigon opened this issue Apr 25, 2018 · 22 comments
Closed

Timeout or not connected to KeePassXC #130

bigon opened this issue Apr 25, 2018 · 22 comments
Labels

Comments

@bigon
Copy link

bigon commented Apr 25, 2018

Hi,

With firefox 59, keepassxc-browser 1.0.1 and keepassxc 2.3.1 on debian unstable I get " Cannot encrypt message or public key not found. Is native messaging or support for your browser enabled in KeePassXC? " the first time I'm opening firefox.

If I start and then quit keepassxc, I then see: "Timeout or not connected to KeePassXC"

Edit: There is a reload button, but no options to start and unlock the db

@varjolintu
Copy link
Member

If you want the browser extension to control (launch and quit) KeePassXC please disable the proxy (meaning keepassxc-proxy process) from the Browser Integration's Advanced settings.

By default, KeePassXC must be started for the connection to be established and database must be opened for making the connection permanent to your current database.

@bigon
Copy link
Author

bigon commented Apr 25, 2018

The error messages are less than optional here, maybe that could be improved?

@varjolintu
Copy link
Member

You can always provide the logs from the debugging console and see if there's any more error messages. You can find it from about:debugging.

@abishai
Copy link

abishai commented Apr 25, 2018

I have partially working extention as well, and this error in particular.
On debug, I see the following error:

13:03:31.220 JSON.parse: unterminated string at line 1 column 61 of the JSON data 1 subprocess_common.jsm:480
	readJSON/< resource://gre/modules/subprocess/subprocess_common.jsm:480:16
readJSON/<

looks like malformed json, but who sends them?

  1. With proxy I need to start keepassxc and login manually
  2. Without proxy keepassxc started automatically and closes after 5 secs.

@varjolintu
Copy link
Member

@abishai That indeed means a malformed JSON. KeePassXC sends it to a proxy, which delivers it to the browser extension. In which situation that error is seen? There's some fixes to the message size and using UTF-8 with the new 2.3.2 release, so if it's possible I suggest trying to compile the sources by yourself from the release/2.3.2 branch and see if it solves the issue.

@abishai
Copy link

abishai commented Apr 25, 2018

@varjolintu this error is seen when extension queries keepassxc status, producing Timeout or not connected to KeePassXC. Strangely, Reload button seems to work (if database is opened)

@varjolintu
Copy link
Member

@abishai That's strange. There shouldn't be any response from keepassxc-proxy if KeePassXC is closed.

@abishai
Copy link

abishai commented Apr 25, 2018

@varjolintu Nope, keepass is not closed. I 100% receive it if I click Block database and extension query database status after it.

@varjolintu
Copy link
Member

Cannot reproduce that one.

@abishai
Copy link

abishai commented Apr 25, 2018

Also, I receive this error if extension autostarts keepassxc (direct connection). It prints malformed json message and closes keepassxc.
So, you are confident that this on keepassxc side ? Probably I need to look into keepassxc code/commits then. :)

@varjolintu
Copy link
Member

@abishai I have seen this kind of behaviour when there's some special characters in the JSON data (fixed in 2.3.2).

@abishai
Copy link

abishai commented Apr 25, 2018

I see. Thank for support, will try to compile 2.3.2

@abishai
Copy link

abishai commented Apr 26, 2018

I applied this one keepassxreboot/keepassxc@3353b32 and looks like error has gone!

@varjolintu
Copy link
Member

@abishai Excellent! So 2.3.2 will definitely deliver the fix for this.

@emeygret
Copy link

Hello, I have the same issue timeout with keepassxc 2.31.
I build 2.3.2 and it seems to be working, but I had to remove this patch whereas build failed on Windows keepassxreboot/keepassxc#1720

@varjolintu
Copy link
Member

@emeygret Looking at this keepassxreboot/keepassxc@062503a you can see a fix was committed 9 hours ago. Try to update the branch and compile again.

@emeygret
Copy link

it is better but missing proxy/NativeMessagingHost.cpp , i had a comment on the fix

@varjolintu
Copy link
Member

Thanks for noticing it. I'll make a new fix.

@bigon
Copy link
Author

bigon commented Apr 27, 2018

Any ETA for a new release?

@varjolintu
Copy link
Member

Soon. That's the all information I have.

@varjolintu varjolintu added the bug label Apr 28, 2018
@varjolintu
Copy link
Member

Please test if this still happens with KeePassXC 2.3.3 and KeePassXC-Browser 1.1.3.

@emeygret
Copy link

for me it is ok, it work fine with 2.3.3/1.1.3,
and Tested during 2 week with 2.3.2/1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants