Add predefined sites option #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
requested changes
Sep 13, 2020
|
https://soundcloud.com/ should be added with the "Detect username only" option IMO. |
|
Can we include an easy way for people to suggest sites to be added to the predefined list? Perhaps lead them to GitHub and a pre-filled issue template? |
|
@droidmonkey That would be nice. |
|
I need to make some more Google-related fix to this. Hold on.. |
varjolintu
force-pushed
the
feature/predefined_sites
branch
from
304abf4
to
9acffc8
Compare
|
We need a rule for |
|
Please also add signin.ebay.com.au |
droidmonkey
requested changes
Oct 31, 2020
varjolintu
force-pushed
the
feature/predefined_sites
branch
from
469640f
to
4881e77
Compare
droidmonkey
approved these changes
Nov 1, 2020
varjolintu
force-pushed
the
feature/predefined_sites
branch
from
79d28e3
to
6a70f44
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option for predefined sites which are added to Site Preferences at the extension start. This feature is enabled by default to ensure a better compatibility with most common sites. Duplicate URL's are not appended to the list.
Another tweaks:
kpxc.initSitePreferences()and do the same check at the extension startPlease report any common sites you know that are missing from the list.
Currently the list is:
Fixes #1033.
Fixes #1042.
Fixes #1073.