Allow filling TOTP without a combination #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varjolintu
added
bug
needs more testing
droidmonkey
approved these changes
Sep 17, 2022
|
@droidmonkey Combination is a predefined "struct" of all detected fields. In this case there's only TOTP field and it's not detected so there's no combination available. Previously a fix for this was done here: #1573 but it didn't cover a case like this. However, I still need to check a few things for this. |
|
Gotcha make sense |
varjolintu
added
2fa
and removed
needs more testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some pages there's no combination detected for the TOTP. It should still be able to fill using the context menu.
Fixes #1649.