Remove special handling for Firefox overflow/hamburger menu #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should do a version detect and choose the right code path. |
varjolintu
force-pushed
the
fix/remove_overflow_menu_exceptions
branch
from
6070815
to
0d3f9f9
Compare
|
This can be implemented now. |
droidmonkey
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox 106 has fixed the bug where the popup was smaller size than the normal one, when it was moved to overflow menu in Firefox's toolbar. The special handling for popup size is now removed.
Previously fixed in: #1571.
Related issue: #721.
This should be merged only after Firefox ESR has the fix. Keeping the WIP state for now.