Small fixes to the options page #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updates the class list on the `<body>` element.
…ting a new database it would not hide the empty row, but this way that bug is fixed, and it is way simpler.
|
Thank you! This is an old bug I never had time to fix :) |
varjolintu
reviewed
Dec 23, 2023
This reverts commit 8022ba4.
varjolintu
approved these changes
Dec 24, 2023
droidmonkey
approved these changes
Dec 24, 2023
|
Personally don't like tables without side borders or vertical lines, they tend to just melt into the background which isn't the intent of a table. I think that table (or all tables) could use a better, darker, border color in dark mode instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm back with some small fixes that I have accumulated over a few months.
It was possible to get the "empty message row" to show up when having things in the table, for example in the list of connected databases. If you add your first connection from the options page then you'll get this:
So I rewrote the logic that hides the row in pure CSS, which makes the code much cleaner and fixes this bug.
I removed
table-borderedfrom the tables since I think it gives the pages a cleaner look. Here's the before/after:Hopefully you like this look better too. 😄
Also fixed some other things, please see the commit messages for more details. Let me know if you want me to change anything.