Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Credential Banner container id #2069

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

varjolintu
Copy link
Member

The Credential Banner's container has an ID that can possibly collide with page content.
Includes some cleanup (Prettier/eslint).

Fixes #2065.

@varjolintu varjolintu added the bug label Jan 6, 2024
@varjolintu varjolintu added this to the 1.8.11 milestone Jan 6, 2024
@varjolintu
Copy link
Member Author

Possible fixes #2009 too.

@varjolintu varjolintu merged commit 364c7fe into develop Jan 6, 2024
@varjolintu varjolintu deleted the fix/rename_banner_container_id branch January 6, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Credential save banner has generic id container clashing with website css
2 participants