Show number of credentials in the extension icon #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, I'll await manifest 3 before review |
varjolintu
force-pushed
the
feature/show_no_credentials_in_toolbar_icon
branch
from
d6f80ef
to
65db1b7
Compare
|
Made the changes needed by Manifest V3. |
droidmonkey
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a suggestion, but the red markers in extension toolbar icon should be restricted to purely error situations. When credentials are found for the site a badge text could indicate how many credentials are found. Some users have reported that the questionmark with the red background seems to indicate an error, and it's not obvious what is currently happening.
Questionmark icons are removed from the sources.
Before:
After: