HTML encode url in ElidedLabel

* Fix #3905 - prevent double quotes and other invalid HTML characters from impeding on display of url in ElidedLabel
keepassxreboot · Nov 23, 2019 · 7e2aa43 · 7e2aa43
1 parent 5c54dfe
commit 7e2aa43
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/gui/widgets/ElidedLabel.cpp b/src/gui/widgets/ElidedLabel.cpp
@@ -105,8 +105,10 @@ void ElidedLabel::updateElidedText()
         const QFontMetrics metrix(font());
         displayText = metrix.elidedText(m_rawText, m_elideMode, width() - 2);
     }
-    setText(m_url.isEmpty() ? displayText : htmlLinkTemplate.arg(m_url, displayText));
-    setOpenExternalLinks(!m_url.isEmpty());
+
+    bool hasUrl = !m_url.isEmpty();
+    setText(hasUrl ? htmlLinkTemplate.arg(m_url.toHtmlEscaped(), displayText) : displayText);
+    setOpenExternalLinks(!hasUrl);
 }
 
 void ElidedLabel::resizeEvent(QResizeEvent* event)