Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password is not copied when other text is selected in KeePassXC #10734

Open
Natan-Gorecki opened this issue May 11, 2024 · 3 comments · May be fixed by #10853
Open

Password is not copied when other text is selected in KeePassXC #10734

Natan-Gorecki opened this issue May 11, 2024 · 3 comments · May be fixed by #10853
Labels

Comments

@Natan-Gorecki
Copy link

Overview

image
Looks like with selected text "Copy username" and "Copy URL" buttons works correctly, but not "Copy password" button.

Steps to Reproduce

For the attached screenshot:

  1. Select Description from Notes.
  2. Click "Copy password" button.

Expected Behavior

The password value is copied (here "Password").

Actual Behavior

The selected text is copied (here "Description").

Context

KeePassXC - Version 2.7.8
Revision: f6757d3

Qt 5.15.11
Debugging mode is disabled.

Operating system: Windows 10 Version 2009
CPU architecture: x86_64
Kernel: winnt 10.0.19045

Enabled extensions:
- Auto-Type
- Browser Integration
- Passkeys
- SSH Agent
- KeeShare
- YubiKey
- Quick Unlock

Cryptographic libraries:
- Botan 3.1.1
@tatarmb4s
Copy link

tatarmb4s commented May 21, 2024

I have the same issue, I can not copy any kind of passwords from Keepass since yesturday. I have even updated to the latest version. I can not even copy the debug info, none of the copy methods works in the app. I can only use the auto typer.

App version

KeePassXC - Version 2.7.8
Revision: f6757d3

Qt 5.15.11
Debugging mode is disabled.

Operating system: Windows 11 Version 2009
CPU architecture: x86_64
Kernel: winnt 10.0.19045

Enabled extensions:
- Auto-Type
- Browser Integration
- Passkeys
- SSH Agent
- KeeShare
- YubiKey
- Quick Unlock

Cryptographic libraries:
- Botan 3.1.1

@tatarmb4s
Copy link

Update: Tested Version 2.7.7 on the same system using the same extensions, and still no copy. The 2.7.6 works.

@iodar
Copy link

iodar commented May 23, 2024

Summary

Same here on linux as well. It seems to be a cross platform issue.

Debug Information

KeePassXC - Version 2.7.8
Revision: f6757d3
Distribution: Flatpak

Qt 5.15.10
Debugging mode is disabled.

Operating system: KDE Flatpak runtime
CPU architecture: x86_64
Kernel: linux 6.1.0-21-amd64

Enabled extensions:
- Auto-Type
- Browser Integration
- Passkeys
- SSH Agent
- KeeShare
- YubiKey
- Secret Service Integration

Cryptographic libraries:
- Botan 3.3.0

System Information

OS: Debian GNU/Linux 12 (bookworm) x86_64 
Host: ThinkPad 
Kernel: 6.1.0-21-amd64 
Shell: bash 5.2.15 
Resolution: 1920x1080 
DE: Plasma 5.27.5 
WM: kwin 
CPU: Intel i5-8365U (8) @ 4.100GHz 
GPU: Intel WhiskeyLake-U GT2 [UHD Graphics 620] 
Memory: 4490MiB / 39736MiB 

Workaround

  • Install version 2.7.4 from PPA repository using apt-get

c4rlo added a commit to c4rlo/keepassxc that referenced this issue Jun 2, 2024
When the user chooses to copy the password for an entry to the
clipboard, previously there was logic to check if text was selected, and
if so, that text was instead copied to the clipboard. That made sense if
(a) the user invoked the Copy Password action via its keyboard shortcut,
and (b) that keyboard shortcut was configured (as per default) to be
Ctrl-C, i.e. the same as the system action for copy-to-clipboard.

However, it made no sense if the user invoked that action in some other
way, for example by clicking the corresponding toolbar button.

It also made no sense in the case that the Copy Password action had some
other keyboard shortcut assigned. Also, if some other action had Ctrl-C
assigned, the logic would not kick in then.

Fix all of the above by modifying the keyboard shortcut logic to
intervene precisely in the case where a shortcut is pressed that matches
the system copy-to-clipboard shortcut; only in that case do we now check
if text is selected and if so copy that to the clipboard instead of the
action we would otherwise take.

Fixes keepassxreboot#10734.
@c4rlo c4rlo linked a pull request Jun 2, 2024 that will close this issue
c4rlo added a commit to c4rlo/keepassxc that referenced this issue Jun 3, 2024
When the user chooses to copy the password for an entry to the
clipboard, previously there was logic to check if text was selected, and
if so, that text was instead copied to the clipboard. That made sense if
(a) the user invoked the Copy Password action via its keyboard shortcut,
and (b) that keyboard shortcut was configured (as per default) to be
Ctrl-C, i.e. the same as the system action for copy-to-clipboard.

However, it made no sense if the user invoked that action in some other
way, for example by clicking the corresponding toolbar button.

It also made no sense in the case that the Copy Password action had some
other keyboard shortcut assigned. Also, if some other action had Ctrl-C
assigned, the logic would not kick in then.

Fix all of the above by modifying the keyboard shortcut logic to
intervene precisely in the case where a shortcut is pressed that matches
the system copy-to-clipboard shortcut; only in that case do we now check
if text is selected and if so copy that to the clipboard instead of the
action we would otherwise take.

Fixes keepassxreboot#10734.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants