Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave browser integration #2414

Closed
tneo opened this issue Oct 24, 2018 · 31 comments
Closed

Brave browser integration #2414

tneo opened this issue Oct 24, 2018 · 31 comments

Comments

@tneo
Copy link

tneo commented Oct 24, 2018

The latest version of the Brave browser is based on the chromium code base. This allows the browser to install Chrome webstore extensions. It would be awesome that the keepassxc browser integration can be checked on in the keepassxc application as there is support for Chrome, Chromium, Firefox and Vivaldi.

@droidmonkey
Copy link
Member

That's interesting considering Brave's stance on extensions under Muon engine was: NO

Technically it should work out of the box with absolutely no code changes since the Chromium base looks at the registry entry for Chrome to determine the location of the native messaging client.

@droidmonkey
Copy link
Member

Yup confirmed, works great.

@tneo
Copy link
Author

tneo commented Oct 25, 2018

I run on OpenSUSE and no matter what I do, I don't get the connection to work with Brave. It works for me in Vivaldi.

@droidmonkey
Copy link
Member

Oh that was an important piece of info...

@varjolintu
Copy link
Member

varjolintu commented Oct 25, 2018

@tneo See this. Maybe you need to add a symbolic link under ~/.brave, if that's the location for configuration files.

@tneo
Copy link
Author

tneo commented Oct 25, 2018

@varjolintu I'm not sure where to add the symlink. I added in the root for Brave browser config. But there is no change in behaviour.

@varjolintu
Copy link
Member

@tneo Are you sure about the location for Brave config or native messaging scripts?

@tneo
Copy link
Author

tneo commented Nov 2, 2018

@varjolintu As far as I know everything resides in ~/.config/BraveSoftware/Brave-Browser/ and there is where I added the symlink.

@varjolintu
Copy link
Member

And the script is inside nativemessaging path? If it still doesn't work, I'll run some tests.

@tneo
Copy link
Author

tneo commented Nov 3, 2018

The script/ json is in ~/.config/chromium/NativeMessagingHosts/

@varjolintu
Copy link
Member

I meant the path Brave uses.

@tneo
Copy link
Author

tneo commented Nov 3, 2018

That is also there. .config/BraveSoftware/Brave-Browser/NativeMessagingHosts/

@varjolintu
Copy link
Member

Maybe you could inspect the correct location using strace when starting Brave.

@tneo
Copy link
Author

tneo commented Nov 4, 2018

These are the only entries with NativeMessagingHosts in there:

access("/home/tneo/.config/BraveSoftware/Brave-Browser", F_OK) = 0
access("/home/tneo/.config/BraveSoftware/Brave-Browser/NativeMessagingHosts", F_OK) = 0
lstat("/home", {st_mode=S_IFDIR|0755, st_size=18, ...}) = 0
lstat("/home/tneo", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
lstat("/home/tneo/.config", {st_mode=S_IFDIR|0700, st_size=8192, ...}) = 0
lstat("/home/tneo/.config/BraveSoftware", {st_mode=S_IFDIR|0700, st_size=27, ...}) = 0
lstat("/home/tneo/.config/BraveSoftware/Brave-Browser", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0
lstat("/home/tneo/.config/BraveSoftware/Brave-Browser/NativeMessagingHosts", {st_mode=S_IFDIR|0700, st_size=6, ...}) = 0
access("/etc/opt/chrome/native-messaging-hosts", F_OK) = 0
lstat("/etc", {st_mode=S_IFDIR|0755, st_size=5962, ...}) = 0
lstat("/etc/opt", {st_mode=S_IFDIR|0755, st_size=12, ...}) = 0
lstat("/etc/opt/chrome", {st_mode=S_IFDIR|0755, st_size=44, ...}) = 0
lstat("/etc/opt/chrome/native-messaging-hosts", {st_mode=S_IFDIR|0755, st_size=78, ...}) = 0

@varjolintu
Copy link
Member

The browser should try to load org.keepassxc.keepassxc_browser.json but it seems that is not included in your file operations.

@tneo
Copy link
Author

tneo commented Nov 6, 2018

As that is not in the directory .config/BraveSoftware/Brave-Browser/NativeMessagingHosts
That only resides in the .config/chromium/NativeMessagingHosts

Adding the symlink to org.keepassxc.keepassxc_browser.json in .config/BraveSoftware/Brave-Browser/NativeMessagingHosts makes integration work.

@lsorba
Copy link

lsorba commented Feb 11, 2019

Getting the same problem with Brave on Mac Version 0.59.35 Chromium: 72.0.3626.81 (Official Build) (64-bit).
In the browser's extension page I get No connected databases found.
I enabled integration for the broswers Chromium / Google Chrome.

EDIT

mkdir ~/Library/Application\ Support/BraveSoftware/Brave-Browser/NativeMessagingHosts/
ln -s ~/Library/Application\ Support/Chromium/NativeMessagingHosts/org.keepassxc.keepassxc_browser.json

doesn't solve the issue on a mac.

find . -name org.keepassxc.keepassxc_browser.json
./Library/Application Support/Chromium/NativeMessagingHosts/org.keepassxc.keepassxc_browser.json
./Library/Application Support/BraveSoftware/Brave-Browser/NativeMessagingHosts/org.keepassxc.keepassxc_browser.json

@FWDekker
Copy link

FWDekker commented Mar 1, 2019

Edit: Scrap that. The KeePassXC-Browser plugin works just fine on Windows if you enable Chrome/Vivaldi support. Maybe rename it to Chrome/Vivaldi/Brave?

@droidmonkey
Copy link
Member

This issue is aimed at Linux.

@MichaelThessel
Copy link

Can confirm this here. I cannot connect the database. I enabled integrations for all browsers just in case.

Running Brave: Version 0.60.47 Chromium: 72.0.3626.119 (Official Build) unknown (64-bit)
on Linux

@mjgiarlo
Copy link

mjgiarlo commented Mar 5, 2019

@tneo 💬

As that is not in the directory .config/BraveSoftware/Brave-Browser/NativeMessagingHosts
That only resides in the .config/chromium/NativeMessagingHosts

Adding the symlink to org.keepassxc.keepassxc_browser.json in .config/BraveSoftware/Brave-Browser/NativeMessagingHosts makes integration work.

This worked for me. Thanks, @tneo!

@therealtakeshi
Copy link

Running Brave Version 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit) on macOS High Sierra.

I tried a few different things, and I was only able to get it working only once I 1) enabled integration support for Chrome and 2) copied that JSON file from Chrome's NativeMessagingHosts directory into Brave's. The same steps but with Chromium or Vivaldi instead of Chrome did not work.

@wranvaud
Copy link

wranvaud commented Apr 3, 2019

Can this be reopened? I'm having this issue on ubuntu and creating symlinks is a workaround only

@varjolintu
Copy link
Member

This issue is still open. We don't provide an official support for Brave browser. Creating symlinks is your only solution for now.

@mjgiarlo
Copy link

mjgiarlo commented Apr 3, 2019

I've just started working on a PR to add Brave integration to KeePassXC: #2933

I still need to build and test it (on Linux), and I'm happy to have more 👀 on the PR as it's been years since I touched C++. If anyone is inclined to partner up on this, let me know. I hope to find time later this week to resume this work.

mjgiarlo added a commit to mjgiarlo/keepassxc that referenced this issue Apr 3, 2019
mjgiarlo added a commit to mjgiarlo/keepassxc that referenced this issue Apr 3, 2019
mjgiarlo added a commit to mjgiarlo/keepassxc that referenced this issue Apr 4, 2019
mjgiarlo added a commit to mjgiarlo/keepassxc that referenced this issue Apr 4, 2019
@ACheshirov
Copy link

The lack of Brave support is the only thing that stops me from switching to KeePassXC.

@mjgiarlo
Copy link

mjgiarlo commented Apr 5, 2019

@ACheshirov 💬

The lack of Brave support is the only thing that stops me from switching to KeePassXC.

The workarounds listed above are fairly straightforward to apply if you're super eager to make the jump. In the meantime #2933 is ready for review.

droidmonkey added a commit to mjgiarlo/keepassxc that referenced this issue Apr 6, 2019
droidmonkey added a commit to mjgiarlo/keepassxc that referenced this issue Apr 7, 2019
@mjgiarlo
Copy link

mjgiarlo commented Apr 8, 2019

#2933 has now been merged into the 2.4.1 release branch. Once KPXC 2.4.1 is released, we can close this issue.

@mjgiarlo
Copy link

@droidmonkey 🎉 thank you!

@marlluslustosa
Copy link

As that is not in the directory .config/BraveSoftware/Brave-Browser/NativeMessagingHosts
That only resides in the .config/chromium/NativeMessagingHosts

Adding the symlink to org.keepassxc.keepassxc_browser.json in .config/BraveSoftware/Brave-Browser/NativeMessagingHosts makes integration work.

This worked for me!

@rasdehya
Copy link

@tneo Thanks.

Adding the symlink to org.keepassxc.keepassxc_browser.json in .config/BraveSoftware/Brave-Browser/NativeMessagingHosts makes integration work.

Still needed in debian buster stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests