New entry is lost when canceling and then saving #3141
Comments
|
I thought I fixed this problem. Sorry for the data loss. For future reference, pressing Ctrl+Enter is the same as pressing OK. |
|
confirmed this is a big problem |
droidmonkey
added a commit
that referenced
this issue
May 31, 2019
* Fixes #3141 * Clearing the entry edit widget prior to emitting the editFinished signal caused the widget to be marked modified and prevent new entries from being created. Use an explicit boolean to notify commit success. * Don't clear password generator on canceling a cancel * Don't discard changes if saving from a cancel produces an error
droidmonkey
added a commit
that referenced
this issue
May 31, 2019
* Fixes #3141 * Clearing the entry edit widget prior to emitting the editFinished signal caused the widget to be marked modified and prevent new entries from being created. Use an explicit boolean to notify commit success. * Don't clear password generator on canceling a cancel * Don't discard changes if saving from a cancel produces an error
droidmonkey
added a commit
that referenced
this issue
May 31, 2019
* Fixes #3141 * Clearing the entry edit widget prior to emitting the editFinished signal caused the widget to be marked modified and prevent new entries from being created. Use an explicit boolean to notify commit success. * Don't clear password generator on canceling a cancel * Don't discard changes if saving from a cancel produces an error
|
Thanks, works! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
After creating a new entry and adding data you can press the escape key or cancel button to trigger the 'Entry has unsaved changes' dialog. Clicking 'Save' should close the dialog and add a new item to the tree.
Current Behavior
Clicking 'Save' does the same thing as 'Discard' - it closes the new entry and drops the new data.
The entered data are lost!
Possible Solution
Not pressing 'Save'! Pressing 'Cancel' lets you at least return to the new entry and continue.
This seems related to the closed issue #1133 (apply key was removed as solution apparently...). Maybe you should remove the 'Save' button as well if you can't fix this.
Steps to Reproduce
Context
I wanted to save without using the mouse and thought that 'Escape' is a nice trigger.
Debug Info
KeePassXC - Version 2.4.1
Revision: 7bafe65
Qt 5.9.5
Debugging mode is disabled.
Operating system: Ubuntu 18.04.2 LTS
CPU architecture: x86_64
Kernel: linux 4.15.0-48-generic
Enabled extensions:
Cryptographic libraries:
libgcrypt 1.8.1
The text was updated successfully, but these errors were encountered: