Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incessant nagging to destroy KeePassHttp rules #3346

Closed
robdevops opened this issue Jul 1, 2019 · 6 comments
Closed

Incessant nagging to destroy KeePassHttp rules #3346

robdevops opened this issue Jul 1, 2019 · 6 comments

Comments

@robdevops
Copy link

KeePassXC 2.4.3 displays this dialog each time the database is unlocked:
image
I have a mixed environment where I often use KeePass 2.x and other KeePass apps, and I don't want to destroy these settings. I am happy for each KeePass app to maintain its own browser ACLs.

Expected Behavior

  • I want to be able to say "No and don't ask me again".
  • This message should warn you it will destroy KeePassHTTP settings, for users who share their database with other KeePass apps.

Current Behavior

I am given the same prompt at every unlock.

Possible Solution

Add a "Never" button to the dialog, or only ever ask once by storing a variable in the database which says the import has been done.

Steps to Reproduce

  1. Add a custom attribute to an entry:
    Name: KeePassHttp Settings
    Content: {"Allow":["example.com"],"Deny":[]}
  2. Lock then unlock the database.

Context

Having to click No at every unlock annoying.
A couple of times I have clicked yes without fully understanding what this does, and had to rebuild my KeePassHttp ACLs from scratch for use with other KeePass apps.

Debug Info

KeePassXC - Version 2.4.3
Revision: 5d6ef0c

Qt 5.12.3
Debugging mode is disabled.

Operating system: macOS Mojave (10.14)
CPU architecture: x86_64
Kernel: darwin 18.5.0

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • SSH Agent
  • KeeShare (signed and unsigned sharing)
  • YubiKey
  • TouchID

Cryptographic libraries:
libgcrypt 1.8.4

@robdevops robdevops added the bug label Jul 1, 2019
@varjolintu
Copy link
Member

Duplicate of #3327.

@droidmonkey
Copy link
Member

Actually I think your PR to fix 3327 should also include a checkbox in the conversion request to not ask again. The http settings can live side by side with custom data settings.

@robdevops
Copy link
Author

Actually I think your PR to fix 3327 should also include a checkbox in the conversion request to not ask again. The http settings can live side by side with custom data settings.

That would be useful. The fix for #3327 is "Prompt to migrate KeePassHTTP settings only if Browser Integration is enabled". My use case is different, as I do use KeePassXC's browser integration.

@varjolintu
Copy link
Member

I'll do the checkbox feature.

@phoerious
Copy link
Member

phoerious commented Jul 2, 2019

You do know that you can use KeePassXC in Windows as well, right? I cannot recommend using the old KeePassHTTP extensions. Besides the fact that every account on your system can communicate and with it, they also lack some essential protections against in-browser password theft.

@mendhak
Copy link

mendhak commented Sep 3, 2019

Please can this be reopened - the fix for #3327 didn't include a checkbox.

Like OP we're also in a mixed environment of KeePassXC and KeePass2 so it would be useful to allow the old `KeePassHttp Settings' to remain by user choice. (Fully aware that KeePassXC works on Windows! However, migrating teams takes time as we wait on various features/issues in the pipeline)

Ignore, I wasn't able to find it earlier:

Just spotted the PR which includes a checkbox: #3349

And it is flagged for v2.5.0

Thanks @varjolintu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants