[2.6.1] -WITH_XC_UPDATECHECK=OFF does not prevent KXC from asking user to check for updates

[Germano0]

Fedora co-maintainer here.
-WITH_XC_UPDATECHECK=OFF should disable automatic updates check at KeepassXC startup. By the way I have been reported by Fedora users that the first time you run KeepassXC (from a clean OS installation, I tried myself too), you will be prompted for Would you like KeePassXC to check for updates on startup? After the user answers the question, a flag UpdateCheckMessageShown=true is added to file ~/.config/keepassxc/keepassxc.ini
The flag should prevent KeepassXC from asking this question.

[droidmonkey]

Your flag is incorrect, should be -DWITH_XC_UPDATECHECK=OFF the question is properly guarded:

keepassxc/src/gui/MainWindow.cpp

Lines 968 to 989 in fd3cc7e

	void MainWindow::performUpdateCheck()
	{
	#ifdef WITH_XC_UPDATECHECK
	if (!config()->get(Config::UpdateCheckMessageShown).toBool()) {
	auto result =
	MessageBox::question(this,
	tr("Check for updates on startup?"),
	tr("Would you like KeePassXC to check for updates on startup?") + "\n\n"
	+ tr("You can always check for updates manually from the application menu."),
	MessageBox::Yes | MessageBox::No,
	MessageBox::Yes);
	config()->set(Config::GUI_CheckForUpdates, (result == MessageBox::Yes));
	config()->set(Config::UpdateCheckMessageShown, true);
	}
	if (config()->get(Config::GUI_CheckForUpdates).toBool()) {
	updateCheck()->checkForUpdates(false);
	}
	#endif
	}