Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password field in "password generator" window uses variable font #8709

Closed
rextheleopard opened this issue Oct 30, 2022 · 3 comments · Fixed by #8732
Closed

Password field in "password generator" window uses variable font #8709

rextheleopard opened this issue Oct 30, 2022 · 3 comments · Fixed by #8732
Labels
bug regression user interface

Comments

@rextheleopard
Copy link

rextheleopard commented Oct 30, 2022 •
edited

Windows 11 10.0.25231.1000 x64
KeepassXC 2.7.4 x64

Password field in "password generator" window uses variable font "Segoe UI". I think all password fields must use fixed fonts.
@rextheleopard rextheleopard changed the title Password field in password generate window display by variable font Password field in "password generator" window using variable font Oct 30, 2022
@rextheleopard rextheleopard changed the title Password field in "password generator" window using variable font Password field in "password generator" window uses variable font Oct 30, 2022
@Teknomancer
Copy link

This regression is also present on Linux.

Linux Mint 20.3 x86_64
KeepassXC 2.7.4 x64

@ritzmann
Copy link

Same thing on macOS 12.6.1, KeepassXC 2.7.4.

@phoerious
Copy link
Member

phoerious commented Nov 2, 2022 •
edited

This was introduced in 7e8a672. The line for setting the font wasn't actually removed, but it also wasn't updated properly, so it now applies to the new parent widget and not the input field.

phoerious added a commit that referenced this issue Nov 2, 2022
@phoerious
Set password input field font correctly.
a76fe6d 
Also update member variable names to describe their contents better.

Fixes #8709
@phoerious phoerious mentioned this issue Nov 2, 2022
Merged
phoerious added a commit that referenced this issue Nov 2, 2022
@phoerious
Set password input field font correctly. (#8732)
3cbe4df 
Also update member variable names to describe their contents better.

Fixes #8709
phoerious added a commit that referenced this issue Nov 2, 2022
@phoerious
Set password input field font correctly. (#8732)
9ba88e2 
Also update member variable names to describe their contents better.

Fixes #8709
pull bot pushed a commit to shonker/keepassxc that referenced this issue Nov 2, 2022
@phoerious @pull
Set password input field font correctly. (keepassxreboot#8732)
1fb727b 
Also update member variable names to describe their contents better.

Fixes keepassxreboot#8709
pull bot pushed a commit to tigerwill90/keepassxc that referenced this issue Nov 3, 2022
@phoerious @pull
Set password input field font correctly. (keepassxreboot#8732)
a1319c6 
Also update member variable names to describe their contents better.

Fixes keepassxreboot#8709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set password input field font correctly keepassxreboot/keepassxc
4 participants
@ritzmann @phoerious @Teknomancer @rextheleopard