Re-register global D-Bus menu when restoring window from tray #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoerious
force-pushed
the
hotfix/271-dbus-menu-ubuntu
branch
2 times, most recently
from
b376896
to
71784cd
Compare
phoerious
changed the title
Don't try to use theme icons for the system tray, resolves #194
phoerious
force-pushed
the
hotfix/271-dbus-menu-ubuntu
branch
from
5696e91
to
2aed33e
Compare
phoerious
force-pushed
the
release/2.1.2
branch
from
6aea066
to
d1b4033
Compare
phoerious
added a commit
that referenced
this pull request
Feb 17, 2017
- Ask for save location when creating a new database [#302] - Remove Libmicrohttpd dependency to clean up the code and ensure better OS X compatibility [#317, #265] - Prevent Qt from degrading Wifi network performance on certain platforms [#318] - Visually refine user interface on OS X and other platforms [#299] - Remove unusable tray icon setting on OS X [#293] - Fix compositing glitches on Ubuntu and prevent flashing when minimizing to the tray at startup [#307] - Fix AppImage tray icon on Ubuntu [#277, #273] - Fix global menu disappearing after restoring KeePassXC from the tray on Ubuntu [#276] - Fix result order in entry search [#320] - Enable HiDPI scaling on supported platforms [#315] - Remove empty directories from installation target [#282]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #271
Description
Ubuntu Unity unregisters global menus when the connected window is hidden. This leaves KeePassXC without a working menu bar when the the window is restored from the system tray.
This patch manually sends a D-Bus call to re-register the window. Unfortunately, it adds D-Bus as a direct dependency on Linux, but I couldn't find another working solution except for disabling native menus altogether.
How Has This Been Tested?
I compiled an AppImage with Qt 5.8 and tested it in an Ubuntu 16.04 virtual machine and on Arch with KDE Plasma 5.9. Plasma 5.9 has never had issues to begin with (because windows weren't automatically unregistered), but it also doesn't show duplicate menus or any other weird behavior after this patch.
Types of changes
Checklist: