Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring KeepassHTTP confirmation window to the front #466

Merged
merged 1 commit into from Apr 8, 2017
Merged

Bring KeepassHTTP confirmation window to the front #466

merged 1 commit into from Apr 8, 2017

Conversation

weslly
Copy link
Contributor

@weslly weslly commented Apr 4, 2017

closes #460

Description

Bring KeepassHTTP confirmation window to the foreground when the browser makes a request.

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@droidmonkey
Copy link
Member

Are the window flags reset at some point? This seems like it would cause the window to always be on top even when you are done with the http selection.

@weslly
Copy link
Contributor Author

weslly commented Apr 5, 2017

@droidmonkey It applied the flags only on the confirmation dialog but I changed them to be called from this-> just to be sure.

@droidmonkey
Copy link
Member

droidmonkey commented Apr 5, 2017

Good point, I thought this was being applied to the main window (duh).

I want to deploy this as part of 2.1.4 along with the HTTP version fix. Can you please rebase this onto the new release/2.1.4 branch?

@droidmonkey droidmonkey changed the base branch from develop to release/2.1.4 April 5, 2017 02:24
@droidmonkey droidmonkey changed the base branch from release/2.1.4 to develop April 5, 2017 02:24
@weslly weslly changed the base branch from develop to release/2.1.4 April 5, 2017 19:37
@weslly
Copy link
Contributor Author

weslly commented Apr 5, 2017

@droidmonkey done 👍

@droidmonkey droidmonkey merged commit aba0633 into keepassxreboot:release/2.1.4 Apr 8, 2017
@weslly weslly deleted the fix/http-confirmation-window branch April 8, 2017 21:58
@phoerious phoerious added this to the v2.2.0 milestone Apr 9, 2017
@droidmonkey droidmonkey modified the milestones: v2.1.4, v2.2.0 Apr 9, 2017
ulich added a commit to ulich/keepassxc that referenced this pull request Jan 6, 2020
Fixes keepassxreboot#466

So it can be displayed in the autocomplete list when more than
one login matches. For users that use groups and have similar names
for multiple logins but organized in different groups
ulich added a commit to ulich/keepassxc that referenced this pull request Feb 20, 2020
Fixes keepassxreboot#466

So it can be displayed in the autocomplete list when more than
one login matches. For users that use groups and have similar names
for multiple logins but organized in different groups
ulich added a commit to ulich/keepassxc that referenced this pull request Feb 20, 2020
Fixes keepassxreboot#466

So it can be displayed in the autocomplete list when more than
one login matches. For users that use groups and have similar names
for multiple logins but organized in different groups
droidmonkey pushed a commit to ulich/keepassxc that referenced this pull request Mar 6, 2020
Fixes keepassxreboot#466

So it can be displayed in the autocomplete list when more than
one login matches. For users that use groups and have similar names
for multiple logins but organized in different groups
droidmonkey pushed a commit that referenced this pull request Mar 7, 2020
Fixes #466

So it can be displayed in the autocomplete list when more than
one login matches. For users that use groups and have similar names
for multiple logins but organized in different groups
lerignoux pushed a commit to lerignoux/keepassxc that referenced this pull request May 28, 2020
Fixes keepassxreboot#466

So it can be displayed in the autocomplete list when more than
one login matches. For users that use groups and have similar names
for multiple logins but organized in different groups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants