Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Password Generator Widget UI/UX #5129

Merged
merged 1 commit into from Aug 6, 2020

Conversation

droidmonkey
Copy link
Member

Screenshots

image
image
image
image

Testing strategy

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@Noir-
Copy link

Noir- commented Aug 3, 2020

Nice work! But why is the "advanced" button next to the character count now? The original position next to the character options made a lot more sense.

@droidmonkey
Copy link
Member Author

droidmonkey commented Aug 3, 2020

Its cleaner tucked up there

* Fix #5098 - Ensure advanced mode settings are saved distinctly from simple mode settings
* Make selected character groups pop out in the UI
* Improve layout of character options
@droidmonkey droidmonkey merged commit 1f4c7cc into release/2.6.1 Aug 6, 2020
@droidmonkey droidmonkey deleted the hotfix/password-generator branch August 6, 2020 22:09
phoerious added a commit that referenced this pull request Aug 19, 2020
Added

- Add menu entries for auto-typing only username or only password [#4891]
- Browser: Add command for retrieving current TOTP [#5278]
- Improve man pages [#5010]
- Linux: Support Xfce screen lock signals [#4971]
- Linux: Add OARS metadata to AppStream markup [#5031]
- SSH Agent: Substitute tilde with %USERPROFILE% on Windows [#5116]

Changed

- Improve password generator UI and UX [#5129]
- Do not prompt to restart if switching the theme back and forth [#5084]
- Change actions for F1, F2, and F3 keys [#5082]
- Skip referenced passwords in health check report [#5056]
- Check system-wide Qt translations directory for downstream translations packaging [#5064]
- macOS: Change password visibility toggle shortcut to Ctrl+H to avoid conflict with system shortcut [#5114]
- Browser: Only display domain name in browser access confirm dialog to avoid overly wide window sizes [#5214]

Fixed

- Fix clipboard not being cleared when database is locked while timeout is still active [#5184]
- Fix list of previous databases not being cleared in some cases [#5123]
- Fix saving of non-data changes on database lock [#5210]
- Fix search results banner theming [#5197]
- Don't enforce theme palette in Classic theme mode and add hover effect for buttons [#5122,#5267]
- Fix label clipping in settings on high-DPI screens [#5227]
- Fix excessive memory usage by icons on systems with high-DPI screens [#5266]
- Fix crash if number of TOTP digits exceeds ten [#5106]
- Fix slot detection when first YubiKey is configured on the second slot [#5004]
- Prevent crash if focus widget gets deleted during saving [#5005]
- Always show buttons for opening or saving attachments [#4956]
- Update link to Auto-Type help [#5228]
- Fix build errors with Ninja [#5121]
- CLI: Fix db-info command wrongly labelled as db-show in usage listing [#5140]
- Windows: Use Classic theme by default if high-contrast mode is on [#5191]
- Linux: Add workaround for qt5ct bug, causing icons not to show up [#5011]
- Linux: Correct high-DPI display by not allowing fractional scaling [#5185]
- Browser: Consider subdomain and path when requesting only "best-matching credentials" [#4832]
- SSH Agent: Always forget all keys on lock [#5115]
aswild added a commit to aswild/keepassxc that referenced this pull request Aug 26, 2020
Release 2.6.1

Added

- Add menu entries for auto-typing only username or only password [keepassxreboot#4891]
- Browser: Add command for retrieving current TOTP [keepassxreboot#5278]
- Improve man pages [keepassxreboot#5010]
- Linux: Support Xfce screen lock signals [keepassxreboot#4971]
- Linux: Add OARS metadata to AppStream markup [keepassxreboot#5031]
- SSH Agent: Substitute tilde with %USERPROFILE% on Windows [keepassxreboot#5116]

Changed

- Improve password generator UI and UX [keepassxreboot#5129]
- Do not prompt to restart if switching the theme back and forth [keepassxreboot#5084]
- Change actions for F1, F2, and F3 keys [keepassxreboot#5082]
- Skip referenced passwords in health check report [keepassxreboot#5056]
- Check system-wide Qt translations directory for downstream translations packaging [keepassxreboot#5064]
- macOS: Change password visibility toggle shortcut to Ctrl+H to avoid conflict with system shortcut [keepassxreboot#5114]
- Browser: Only display domain name in browser access confirm dialog to avoid overly wide window sizes [keepassxreboot#5214]

Fixed

- Fix clipboard not being cleared when database is locked while timeout is still active [keepassxreboot#5184]
- Fix list of previous databases not being cleared in some cases [keepassxreboot#5123]
- Fix saving of non-data changes on database lock [keepassxreboot#5210]
- Fix search results banner theming [keepassxreboot#5197]
- Don't enforce theme palette in Classic theme mode and add hover effect for buttons [keepassxreboot#5122,keepassxreboot#5267]
- Fix label clipping in settings on high-DPI screens [keepassxreboot#5227]
- Fix excessive memory usage by icons on systems with high-DPI screens [keepassxreboot#5266]
- Fix crash if number of TOTP digits exceeds ten [keepassxreboot#5106]
- Fix slot detection when first YubiKey is configured on the second slot [keepassxreboot#5004]
- Prevent crash if focus widget gets deleted during saving [keepassxreboot#5005]
- Always show buttons for opening or saving attachments [keepassxreboot#4956]
- Update link to Auto-Type help [keepassxreboot#5228]
- Fix build errors with Ninja [keepassxreboot#5121]
- CLI: Fix db-info command wrongly labelled as db-show in usage listing [keepassxreboot#5140]
- Windows: Use Classic theme by default if high-contrast mode is on [keepassxreboot#5191]
- Linux: Add workaround for qt5ct bug, causing icons not to show up [keepassxreboot#5011]
- Linux: Correct high-DPI display by not allowing fractional scaling [keepassxreboot#5185]
- Browser: Consider subdomain and path when requesting only "best-matching credentials" [keepassxreboot#4832]
- SSH Agent: Always forget all keys on lock [keepassxreboot#5115]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status of special characters button in password generator is not persisted
3 participants