Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keepass-cr-recovery #7521

Merged
merged 1 commit into from Mar 11, 2022
Merged

Fix keepass-cr-recovery #7521

merged 1 commit into from Mar 11, 2022

Conversation

toelke
Copy link

@toelke toelke commented Mar 11, 2022

keepass-cr-recovery used the challenge unpadded, add padding as in
https://github.com/keepassxreboot/keepassxc/blob/develop/src/keys/drivers/YubiKeyInterfaceUSB.cpp\#L291
https://github.com/keepassxreboot/keepassxc/blob/develop/src/keys/drivers/YubiKeyInterfacePCSC.cpp\#L747

Closes #4744

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #7521 (7bff050) into develop (8f76ea3) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #7521      +/-   ##
===========================================
+ Coverage    64.30%   64.32%   +0.02%     
===========================================
  Files          339      339              
  Lines        43364    43364              
===========================================
+ Hits         27881    27891      +10     
+ Misses       15483    15473      -10     
Impacted Files Coverage Δ
src/core/Entry.cpp 82.65% <0.00%> (-0.10%) ⬇️
src/fdosecrets/dbus/DBusMgr.cpp 53.67% <0.00%> (+1.47%) ⬆️
...rc/fdosecrets/widgets/SettingsWidgetFdoSecrets.cpp 62.16% <0.00%> (+3.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f76ea3...7bff050. Read the comment docs.

@droidmonkey droidmonkey merged commit e6a6ba7 into keepassxreboot:develop Mar 11, 2022
@toelke toelke deleted the fix-keepass-cr-recovery branch March 11, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keepassxc-cr-recovery not functioning
3 participants