Auto-Type: Map ASCII dead keys on Linux #7614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
requested changes
Mar 23, 2022
Special handling of ASCII keys that are common in passwords that may be dead on the current keyboard layout and prevents going to keysym emulation fallback.
hifi
force-pushed
the
fix/autotype-ascii-dead-keys
branch
from
4837979
to
6baa81f
Compare
droidmonkey
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special handling of ASCII keys that are common in passwords that may be dead on the current keyboard layout and prevents going to keysym emulation fallback.
I know the nested loops look awful, sorry.
Helps with #7610 but does not fix the keysym emulation issue.
Testing strategy
Manually.
Type of change