Add 2FA suggestions report #7761
Open
+555
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes keepassxreboot#4096 Signed-off-by: Thomas Hobson <thomas@hexf.me>
Codecov Report
@@ Coverage Diff @@
## develop #7761 +/- ##
===========================================
- Coverage 64.31% 64.10% -0.21%
===========================================
Files 339 341 +2
Lines 43450 43646 +196
===========================================
+ Hits 27943 27979 +36
- Misses 15507 15667 +160
Continue to review full report at Codecov.
|
|
Can we combine this with the password change urls so people can also easily change their password for entries? |
|
This is true, nevermind then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4096 , implementing a report which compares all the URLs in a Keepass database against those from the 2fa.directory dataset, informing the user if they can enable 2FA on accounts, and how to go about doing that.
If no network is available (whether that be through no compiled support or no network), the report simply hides the supported, match, and documentation columns.
Filters are available on the right side to switch between showing entries with 2fa enabled, disabled, supported and not supported in any combination.
Double-clicking on a line in the report will edit the related entry in the database, while double-clicking on the documentation will launch it in a browser.
Screenshots
Testing strategy
Changes were tested manually by adding records with varying 2FA statuses (enabled and disabled), for various different websites known in the 2fa.directory data set.
It was tested that they correctly match, provided the hostnames are equal and that the appropriate level of support is provided.
Type of change