Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on macOS when unlocking database #8676

Merged
merged 1 commit into from Oct 27, 2022
Merged

Conversation

droidmonkey
Copy link
Member

This only affects macOS 13+ due to the use of nullptr when initializing std::string.

Screenshots

Testing strategy

Tested by forcing the use of TouchID code, still needs to be tested in a signed build to ensure all code paths are clean.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@phoerious
Copy link
Member

I'll test it later, but looks good to me.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Base: 64.30% // Head: 64.28% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (20cb6cd) compared to base (422fd91).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8676      +/-   ##
===========================================
- Coverage    64.30%   64.28%   -0.02%     
===========================================
  Files          341      341              
  Lines        44330    44330              
===========================================
- Hits         28502    28495       -7     
- Misses       15828    15835       +7     
Impacted Files Coverage Δ
src/gui/Clipboard.cpp 78.95% <0.00%> (-7.02%) ⬇️
src/core/FileWatcher.cpp 86.75% <0.00%> (-1.20%) ⬇️
src/core/Entry.cpp 82.52% <0.00%> (-0.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phoerious
Copy link
Member

No crash on 12.6 even without the patch. I will have to upgrade to 13 first. This is going to take a while.

@droidmonkey
Copy link
Member Author

Yah it only crashes on 13

@phoerious
Copy link
Member

I cannot even reproduce it on Ventura.

@phoerious
Copy link
Member

But it doesn't do any harm either, so ship it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS: KeePassXC 2.7.3 segfault when unlocking database with quick unlock enabled
3 participants