Cli: Added minimal command autocomplete #8918
Open
+109
−92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of a command autocomplete implemented with linenoise-ng as mentioned in issue #4676.
The autocompletion only starts if at least one character is entered, as far as I understand this is how linenoise works.
The readline dependecy was removed.
In addition to this I removed some warnings which I received when I ran the automatic cli tests.
Fixes #4676
Screenshots
Testing strategy
I tested the autocompletion manually in the terminal.
Currently I try some automatic testing but unfortunately I am not able to get the autocomplete within the tests I wrote.
I think this is due to linenoise because it controls stdin and stdout.
Type of change