Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: note and ticket assignment and presets from alerts selection #762

Merged
merged 18 commits into from
Jan 31, 2024

Conversation

shahargl
Copy link
Member

No description provided.

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 9:29am

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (6ac271e) 55.78% compared to head (d8f0d73) 55.67%.

Files Patch % Lines
keep/api/routes/alerts.py 0.00% 9 Missing ⚠️
keep/api/core/db.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
- Coverage   55.78%   55.67%   -0.12%     
==========================================
  Files          80       80              
  Lines        4926     4938      +12     
==========================================
+ Hits         2748     2749       +1     
- Misses       2178     2189      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talboren talboren changed the title feat: note and assign ticket feat: note and ticket assignment and presets from alerts selection Jan 30, 2024
Copy link
Contributor

@asharonbaltazar asharonbaltazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

keep-ui/utils/hooks/usePresets.ts Show resolved Hide resolved
keep-ui/utils/hooks/useProviders.ts Show resolved Hide resolved
keep-ui/app/alerts/alert-table-tab-panel.tsx Show resolved Hide resolved
keep-ui/app/alerts/alert-note-modal.tsx Outdated Show resolved Hide resolved
keep-ui/app/alerts/alert-note-modal.tsx Outdated Show resolved Hide resolved
@shahargl shahargl merged commit 593161a into main Jan 31, 2024
7 of 9 checks passed
@shahargl shahargl deleted the feature/ux-improvements branch January 31, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants