Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Keep or Sweep for Nextcloud 14, fix #17 #19

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Conversation

jancborchardt
Copy link
Member

Fix the layout according to nextcloud/server#9982, basically only using #app-content.

Please review @xMartin @camilasan @nickvergessen 🙏 also upped the version cause I’ll make a release with that, and with it we will only support Nextcloud 14 and later.

Before & after:
screenshot from 2018-08-14 12-44-07
screenshot from 2018-08-14 12-42-56

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added the bug Something isn't working label Aug 14, 2018
@jancborchardt jancborchardt added this to the v0.2.* milestone Aug 14, 2018
@jancborchardt
Copy link
Member Author

Anyone up for a quick double-check? Maybe @dosch @thatscoteng @Sanookmakmak @aproposnix @happyreacer @borekon?

Any review is appreciated! 😍 🎉

@dosch
Copy link

dosch commented Aug 21, 2018

Alignment is fine!

screen shot 2018-08-21 at 09 29 59

Copy link

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works again

@@ -34,7 +34,7 @@ Currently this works for Files, and we have [plans to integrate many more source
</documentation>

<dependencies>
<nextcloud min-version="12" max-version="14"/>
<nextcloud min-version="14" max-version="15"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldnt claim that is works with 15 now...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but the point is that directly after 14 release the main version for devs will be 15, and nothing initially changes. :)

@aproposnix
Copy link

@jancborchardt sorry for the delay in response. To be honest, I had to remove the app because I have some issues with it. I've gone ahead and reinstalled on the latest 14rc release and the alignment is still broken for me.

Here's a screenshot: http://pix.toile-libre.org/upload/original/1535089951.png

@jancborchardt
Copy link
Member Author

@aproposnix this pull request should fix exactly that alignment issue. :)

It would be great if you could open separate issues for the other problems you encounter with the app too – any help is appreciated. :)

@aproposnix
Copy link

@jancborchardt Sorry. Didn't realize I was reading a pull request ticket. :)

With regards to your other point, it's a usability issue I reported on issue #9
As it is now, I have to be very careful cleaning as I have on multiple occasions, accidentally deleted files not meant for deletion. I hope someone could tackle this request as I think it will add a lot of value for people needing to clean out auto-synced image files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants