Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide actions which user does not have permissions to execute #1022

Closed
luis100 opened this issue May 31, 2017 · 2 comments
Closed

Hide actions which user does not have permissions to execute #1022

luis100 opened this issue May 31, 2017 · 2 comments
Assignees
Milestone

Comments

@luis100
Copy link
Member

luis100 commented May 31, 2017

Use the user repository-level and object-level permissions to infer which actions a user have permissions to execute and hide or disable the ones the user does not.

This will need to bind each button to a Browser controller method, which in its turn is already bound to role(s). It will also may need more information as AIP id in case it needs to check object permissions. The logic could be verified directly on the client if the code to check permissions can be ported and the roda-roles.properties information can be transferred.

The main code that would need to be ported to the client are the UserUtility.checkRoles(...) functions.

Depends on #885 to be complete, but can start before.

@luis100 luis100 added this to the 2.1.0 milestone May 31, 2017
@luis100 luis100 modified the milestones: 2.3.0, 2.1.0 Aug 14, 2017
@chalkos chalkos self-assigned this Jun 26, 2018
@nunovieira220 nunovieira220 removed their assignment Jul 6, 2018
@luis100
Copy link
Member Author

luis100 commented Sep 21, 2018

Also needs to take into consideration the node type, as nodes that are not MASTER (e.g. are SLAVE) cannot perform actions that have an impact other than NONE. To do this the RodaCoreFactory.getNodeType() needs to be transmitted into to client on load (e.g. via shared properties) and used in Actionable.canAct() methods.

@luis100 luis100 self-assigned this Sep 21, 2018
@nunovieira220 nunovieira220 removed their assignment Oct 10, 2018
@nunovieira220
Copy link
Contributor

Everything is done. Please review if something is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants