Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the "nobranding" implementation to support multiple additional CSS instead of just one #1157

Closed
chalkos opened this issue Feb 27, 2018 · 2 comments
Closed

Change the "nobranding" implementation to support multiple additional CSS instead of just one #1157

chalkos opened this issue Feb 27, 2018 · 2 comments
Assignees
@chalkos
Labels
enhancement feature request
Milestone
3.0

Comments

@chalkos
Copy link
Contributor

chalkos commented Feb 27, 2018

The idea is, instead of using in the URL

...?nobranding=true

To use

...?branding=jone.css
...?branding=sclinico.css

to load the indicated css files.
@chalkos chalkos added this to the 2.2.0-beta3 milestone Feb 27, 2018
@chalkos chalkos self-assigned this Feb 27, 2018
@jmaferreira
Copy link
Member

Sim.. mas mantem isso retrocompativel. Ou seja... mantém o suporte para
...?nobranding=true

@hsilva-keep hsilva-keep modified the milestones: 2.2.0-beta3, 2.2.0, 2.3.0 Mar 15, 2018
chalkos added a commit that referenced this issue Jun 1, 2018
@chalkos
fixes #1157 by supporting a css filename to be passed in the 'brandin…
4aaa6b4 
…g' parameter. The css extension may be omitted as it is added automatically. Multiple brading CSS can be used by providing their names separated by commas in the 'branding' parameter, the CSS files are loaded in the order they are specified and after all the base CSS has been loaded. Using 'branding=false' is an alias for 'branding=nobranding.css' in order to keep retrocompatibility.
@chalkos
Copy link
Contributor Author

chalkos commented Jun 1, 2018

Usage:

branding=somebranding.css loads the file somebranding.css from config/theme folder.

branding=somebranding loads the file somebranding.css from config/theme folder.

branding=minimal,contrast loads the file minimal.css and then loads contrast.css from config/theme folder

branding=false does the same as branding=nobranding.css, which loads the file nobranding.css from config/theme folder. This ensures that these changes are retrocompatible.

All branding CSS is loaded after the main CSS has been loaded.

@chalkos chalkos closed this as completed Jun 1, 2018
@jmaferreira jmaferreira reopened this Jun 1, 2018
@keeps keeps deleted a comment from jmaferreira Jun 1, 2018
@chalkos chalkos closed this as completed Jun 1, 2018
luis100 pushed a commit that referenced this issue Jun 5, 2018
@chalkos @luis100
fixes #1157 by supporting a css filename to be passed in the 'brandin…
b04f2cc 
…g' parameter. The css extension may be omitted as it is added automatically. Multiple brading CSS can be used by providing their names separated by commas in the 'branding' parameter, the CSS files are loaded in the order they are specified and after all the base CSS has been loaded. Using 'branding=false' is an alias for 'branding=nobranding.css' in order to keep retrocompatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalkos chalkos

Labels
enhancement feature request
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@chalkos @hsilva-keep @jmaferreira