Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations are not working correctly #1267

Closed
chalkos opened this issue Jul 3, 2018 · 2 comments
Closed

Translations are not working correctly #1267

chalkos opened this issue Jul 3, 2018 · 2 comments
Assignees
@chalkos
Labels
bug
Milestone
3.0

Comments

@chalkos
Copy link
Contributor

chalkos commented Jul 3, 2018

Translations from shared properties in "Collections" page are always showing up in Portuguese. Independently of which language is selected.
@chalkos chalkos added the bug label Jul 3, 2018
@chalkos chalkos added this to the 2.3.0 milestone Jul 3, 2018
@chalkos chalkos self-assigned this Jul 3, 2018
chalkos added a commit that referenced this issue Jul 4, 2018
@chalkos
Fixes #1267 by protecting against overwriting existing cached values;…
f79881f 
… added tests around this to reduce the chances of this problem reappearing.
@chalkos
Copy link
Contributor Author

chalkos commented Jul 4, 2018

Problem was:

  1. user accesses RODA in english
  2. RODA gets the shared properties (and caches them)
  3. RODA adds i18n (english) properties to the ones obtained in 2.
  4. user accesses RODA in portuguese
  5. RODA gets the shared properties from cache (same object as in 2.)
  6. RODA adds i18n (portuguese) properties to the ones obtained in 5, which are the same ones that the english language is using, so they are being overwritten.
  7. user accesses RODA in english
  8. user sees text in portuguese.

giving each language their own copy of the shared properties solved the problem.

@chalkos
Copy link
Contributor Author

chalkos commented Jul 23, 2018

fixed

@chalkos chalkos closed this as completed Jul 23, 2018
@chalkos chalkos removed the to review label Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalkos chalkos

Labels
bug
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@chalkos @luis100