Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Job(report) links in AIP details sidebar #1304

Closed
3 tasks done
chalkos opened this issue Jul 27, 2018 · 1 comment
Closed
3 tasks done

Fix Job(report) links in AIP details sidebar #1304

chalkos opened this issue Jul 27, 2018 · 1 comment
Assignees
@chalkos
Labels
bug enhancement
Milestone
3.0

Comments

@chalkos
Copy link
Contributor

chalkos commented Jul 27, 2018 •
edited
Loading

Changes introduced to fix #1231 broke existing functionality because the job report is now composed of job id, source object id and outcome object id (previously the source object id was not needed).

The new approach is:

  • show job ids in the sidebar
  • clicking it shows the job, but the list of reports should be filtered by outcomeObjectId == aipId
  • if the filtered job report list has only one item, show it automatically
@chalkos chalkos added this to the 2.3.0 milestone Jul 27, 2018
@chalkos chalkos self-assigned this Jul 27, 2018
chalkos added a commit that referenced this issue Jul 27, 2018
@chalkos
Fix #1304 by changing aip sidebar and showjob
32f8733 
jobIds links in the sidebar link to the ShowJob page with a filter to show only reports related to this AIP;
Change ShowJob page to support receiving jobReportList filter parameters via URI;
When filters were provided to the ShowJob page, make the job report list jump to the report page if there is only one report.
chalkos added a commit that referenced this issue Jul 27, 2018
@chalkos
Fix #1304 by changing aip sidebar and showjob
efd58d2 
jobIds links in the sidebar link to the ShowJob page with a filter to show only reports related to this AIP;
Change ShowJob page to support receiving jobReportList filter parameters via URI;
When filters were provided to the ShowJob page, make the job report list jump to the report page if there is only one report.
@chalkos
Copy link
Contributor Author

chalkos commented Jul 30, 2018

fixed.

@chalkos chalkos closed this as completed Jul 30, 2018
chalkos added a commit that referenced this issue Jul 31, 2018
@chalkos
Fix #1304 by changing aip sidebar and showjob
171b899 
jobIds links in the sidebar link to the ShowJob page with a filter to show only reports related to this AIP;
Change ShowJob page to support receiving jobReportList filter parameters via URI;
When filters were provided to the ShowJob page, make the job report list jump to the report page if there is only one report.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalkos chalkos

Labels
bug enhancement
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@chalkos