Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search does superfluous requests to server #1333

Closed
1 of 2 tasks
luis100 opened this issue Sep 5, 2018 · 2 comments
Closed
1 of 2 tasks

Search does superfluous requests to server #1333

luis100 opened this issue Sep 5, 2018 · 2 comments
Assignees
@chalkos
Labels
enhancement
Milestone
3.0

Comments

@luis100
Copy link
Member

luis100 commented Sep 5, 2018 •
edited by chalkos
Loading

  • Avoid retrieveSearchFields requests by using ConfigurationManager
  • Don't do searches on lists when lists are not visible (using Filter.NULL)
@luis100 luis100 added this to the 2.3.0 milestone Sep 5, 2018
@luis100
Copy link
Member Author

luis100 commented Sep 5, 2018

On init search is making 6 find requests and 3 retrieveSearchFields requests.

chalkos added a commit that referenced this issue Sep 5, 2018
@chalkos
Progress on #1333: fix superfluous searches
141faa7 
Searching only occurs when the list is attached and visible;
Pressing enter on the search box or clicking the magnifying glass icon shows the list and triggers a refresh (effectively a first fetch if there was no data in the list yet).
chalkos added a commit that referenced this issue Sep 5, 2018
@chalkos
Fix #1333 by using shared config to get advanced search fields
bbd4458 
Moves org.roda.wui.client.common.utils.StringUtils to org.roda.wui.common.client.tools.StringUtils;
Add advanced search fields properties to the shared propeerties whitelist;
Build advanced search fields on the client using shared properties instead of getting them from the server;
Remove server side advanced search fields generation code.
@chalkos
Copy link
Contributor

chalkos commented Sep 6, 2018

Fixed

@chalkos chalkos closed this as completed Sep 6, 2018
nunovieira220 pushed a commit that referenced this issue Sep 6, 2018
@chalkos @nunovieira220
Progress on #1333: fix superfluous searches
7da2515 
Searching only occurs when the list is attached and visible;
Pressing enter on the search box or clicking the magnifying glass icon shows the list and triggers a refresh (effectively a first fetch if there was no data in the list yet).
luis100 pushed a commit that referenced this issue Sep 6, 2018
@chalkos @luis100
Progress on #1333: fix superfluous searches
8a832c9 
Searching only occurs when the list is attached and visible;
Pressing enter on the search box or clicking the magnifying glass icon shows the list and triggers a refresh (effectively a first fetch if there was no data in the list yet).
luis100 pushed a commit that referenced this issue Sep 6, 2018
@chalkos @luis100
Fix #1333 by using shared config to get advanced search fields
396c9da 
Moves org.roda.wui.client.common.utils.StringUtils to org.roda.wui.common.client.tools.StringUtils;
Add advanced search fields properties to the shared propeerties whitelist;
Build advanced search fields on the client using shared properties instead of getting them from the server;
Remove server side advanced search fields generation code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalkos chalkos

Labels
enhancement
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@chalkos @luis100