Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-resize dialogs with lists when the list contents change #1370

Closed
chalkos opened this issue Oct 8, 2018 · 2 comments
Closed

Auto-resize dialogs with lists when the list contents change #1370

chalkos opened this issue Oct 8, 2018 · 2 comments
Assignees
@chalkos
Labels
bug
Milestone
3.0

Comments

@chalkos
Copy link
Contributor

chalkos commented Oct 8, 2018

This feature was implemented for some lists/dialogs before the search/listOptions refactor.

Implement this in list options and apply it to all dialogs that contain lists.
@chalkos chalkos added the bug label Oct 8, 2018
@chalkos chalkos added this to the 2.3.0 milestone Oct 8, 2018
@chalkos chalkos self-assigned this Oct 8, 2018
chalkos added a commit that referenced this issue Oct 8, 2018
@chalkos
Fix #1361 and #1370
3017235 
Improve dialogs' width across multiple screen sizes (and remove unused leftover CSS classes).
Dialogs containing lists now correctly recenter when the list contents change.
Fix exception on ShowRI (create one from association, then view it): Cannot read property 'getFamilyValues_2_g$' of null.
Fix 'help' section width in RI 'add relations' dialog.
Fix edit associations: if there are no filters, clicking search button does nothing, by making the button disabled when there are no filters.
Fix cancel buttons in RI pages (eg: clicking the cancel button when editing a RI always goes back to the list, even if the user was associating with something).
Jump to RI when associating with new RI.
@chalkos
Copy link
Contributor Author

chalkos commented Oct 8, 2018

The current fix does not use options and instead searches the list's parents and recenters the first dialog that it finds. It should be using an option and set it whenever lists are shown inside dialogs.

chalkos added a commit that referenced this issue Oct 9, 2018
@chalkos
Fix #1370 using options
5cd4b3d 
Adds an option that recenters a given dialog when the list is updated.
@chalkos
Copy link
Contributor Author

chalkos commented Oct 9, 2018

Fixed.

@chalkos chalkos closed this as completed Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalkos chalkos

Labels
bug
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@chalkos