Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External plugins should have their own configs & i18n #785

Closed
hsilva-keep opened this issue Jan 26, 2017 · 1 comment
Closed

External plugins should have their own configs & i18n #785

hsilva-keep opened this issue Jan 26, 2017 · 1 comment
Labels
enhancement
Milestone
Unplanned

Comments

@hsilva-keep
Copy link
Member

ATM, plugins configs are configured in roda-core.properties (which is reloadable when changes happen). But, plugins should have their own config file, which should live inside the config folder (config/plugins/PLUGIN_NAME). This can be solved by creating a convention on filename which should be present in that folder & contain plugin's configurations.
The same goes for i18n.
@hsilva-keep hsilva-keep added this to the 2.1.0 milestone Jan 26, 2017
@hsilva-keep hsilva-keep mentioned this issue May 26, 2017
Closed
@luis100 luis100 modified the milestones: 2.3.0, 2.1.0 Aug 14, 2017
@luis100 luis100 modified the milestones: 2.3.0, Unplanned Oct 31, 2017
luis100 added a commit that referenced this issue Nov 17, 2017
@luis100
Removing VOLUME from Dockerfile, loading all .properties files from p…
f76dabe 
…lugin ffolder relates to #785
@luis100
Copy link
Member

luis100 commented Sep 7, 2018

Plugins already have their own configuration and each can do its own i18n.

@luis100 luis100 closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
2 participants
@luis100 @hsilva-keep