A specific plugin execution thrown an exception yet job have completed with success

[hsilva-keep]

Exception:

2017-03-17 12:08:20,601 [JobsSystem-io-2-dispatcher-54] ERROR o.r.c.p.o.akka.AkkaWorkerActor - Error executing plugin.execute()
java.lang.IllegalAccessError: tried to access method org.roda.core.data.v2.common.Pair.<init>(Ljava/lang/Object;Ljava/lang/Object;)V from class com.databasepreservation.visualization.utils.SolrManager
        at com.databasepreservation.visualization.utils.SolrManager.markDatabaseAsReady(SolrManager.java:556)
        at com.databasepreservation.modules.solr.SolrExportModule.finishDatabase(SolrExportModule.java:182)
        at com.databasepreservation.modules.siard.in.input.SIARDImportDefault.getDatabase(SIARDImportDefault.java:56)
        at org.roda.core.plugins.dbptk.DatabaseVisualizationPlugin.convert(DatabaseVisualizationPlugin.java:568)
        at org.roda.core.plugins.dbptk.DatabaseVisualizationPlugin.convertToViewer(DatabaseVisualizationPlugin.java:340)
        at org.roda.core.plugins.dbptk.DatabaseVisualizationPlugin.executeOnFile(DatabaseVisualizationPlugin.java:295)
        at org.roda.core.plugins.AbstractAIPComponentsPlugin$1.process(AbstractAIPComponentsPlugin.java:39)
        at org.roda.core.plugins.plugins.PluginHelper.processObjects(PluginHelper.java:131)
        at org.roda.core.plugins.AbstractAIPComponentsPlugin.execute(AbstractAIPComponentsPlugin.java:27)
        at org.roda.core.plugins.orchestrate.akka.AkkaWorkerActor.handlePluginExecuteIsReady(AkkaWorkerActor.java:54)
        at org.roda.core.plugins.orchestrate.akka.AkkaWorkerActor.onReceive(AkkaWorkerActor.java:39)
        at akka.actor.UntypedActor$$anonfun$receive$1.applyOrElse(UntypedActor.scala:165)
        at akka.actor.Actor$class.aroundReceive(Actor.scala:496)
        at akka.actor.UntypedActor.aroundReceive(UntypedActor.scala:95)
        at akka.actor.ActorCell.receiveMessage(ActorCell.scala:526)
        at akka.actor.ActorCell.invoke(ActorCell.scala:495)
        at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:257)
        at akka.dispatch.Mailbox.run(Mailbox.scala:224)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)

Job:

{
  "id": "a9245b27-9839-41c8-a659-7b8d8b1fc126",
  "name": "Database Visualization (1.0)",
  "username": "admin",
  "startDate": 1489752412424,
  "state": "COMPLETED",
  "stateDetails": "",
  "jobStats": {
    "completionPercentage": 0,
    "sourceObjectsCount": 1,
    "sourceObjectsBeingProcessed": 1,
    "sourceObjectsWaitingToBeProcessed": 0,
    "sourceObjectsProcessedWithSuccess": 0,
    "sourceObjectsProcessedWithFailure": 0,
    "outcomeObjectsWithManualIntervention": 0
  },
  "plugin": "org.roda.core.plugins.dbptk.DatabaseVisualizationPlugin",
  "pluginType": "MISC",
  "sourceObjects": {
    "type": "list",
    "ids": [
      "85b0439d-6d98-32c3-9c18-0cfa9020f383"
    ],
    "selectedClass": "org.roda.core.data.v2.ip.IndexedFile"
  },
  "outcomeObjectsClass": "",
  "inFinalState": true,
  "stopping": false,
  "endDate": 1489752500617,
  "pluginParameters": {
    "core.plugins.dbptk.siard.ignoreNonSiard": "false",
    "core.plugins.dbptk.siard.extensions": "siard,siard2"
  }
}

[luis100]

the org.roda.core.data.v2.common.Pair constructor visibility was changed to private, should use Pair.of() instead.

[jmaferreira]

We changed it back to public as it was breaking code all over the places... in plugins.
There's no good reason why we shouldn't keep both approaches on. Potencially add a deprecated annotation.

[jmaferreira]

We changed it back to public.

[hsilva-keep]

To summarize, plugin problem was solved by changing Pair constructor back to public (and adding java docs).
The other problem is related to Job orchestration and how Plugin.execute individual failures should be handled.

[luis100]

@hsilva-keep is this still an issue?

[hsilva-keep]

Solved since 1365dd2

[hsilva-keep]

If one or more exceptions occurred (in one or more plugin.execute), textual description of those exceptions is added to job.statedetails...I've kept the state details as a string to avoid introducing changes to the model.

@luis100 assign proper person to handle showing that information (if it exists) in the WUI.

[nunovieira220]

The state details information is already presented when showing a job here