Remove un-necessary panic #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
approved these changes
Oct 29, 2023
thombles
added a commit
to mcginty/mdns-sd
that referenced
this pull request
Jun 6, 2024
Fixes getditto/ditto#12396 Upstream report keepsimple1#143 This PR is a manual cherrypick of upstream fix onto our subrepo: keepsimple1#144 This fixes/removes two explicit panics that can happen in the mDNS parsing. The change itself is safe - it only touches code blocks that contained a `panic!()` anyway, plus comments. The new test passes. I have created a new issue about putting in the work to get us tracking upstream again: getditto/ditto#12733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix issue #143