Allow non-standard max length for a service name #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smith61
reviewed
Mar 6, 2023
src/service_daemon.rs
Outdated
|
|
||
| /// Validate the length of "service_name" in a "_<service_name>.<domain_name>." string. | ||
| fn check_service_name_length(ty_domain: &str, limit: u8) -> Result<()> { | ||
| println!("check_service_name_length: {}", ty_domain); |
|
This PR resolves my issue. The only thing I noticed is the unneeded println in check_service_name_length |
Thanks for checking! I will remove the println and get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to solve issue #94 .
A new method
ServiceDaemon.set_service_name_len_max()is added to support setting a custom max length for the service name.A public constant
SERVICE_NAME_LEN_MAX_DEFAULTis defined for the default / standard value.Service name length error reporting (a trade-off): it will no longer return Error directly from
register()method for service name length errors. Instead, it will be reported in error log andDaemonEvent::Errorreceived by any monitors. The register itself will not succeed in such error cases. See the test case changes for an example.