model: add more locking, and resource handler #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To obtain more a precise Coverity analysis, we add more functions of the kernel to the Coverity model. This way, the analysis finds more problematic code path. Besides adding several locking and memory allocation families, this change also modifies the IS_ERR_OR_NULL function model. When freeing the pointer in this function, many double-free patterns have been reported. Without this change, these problems have not been seen, and we did not loose any other irrelevant defects. Signed-off-by: Norbert Manthey <nmanthey@amazon.de>
|
Looks good! I guess we'll see what happens with the NULL_OR_ERR. The old way didn't work very weird either. :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To obtain more a precise Coverity analysis, we add more functions of the kernel to the Coverity model. This way, the analysis finds more problematic code path.
Besides adding several locking and memory allocation families, this change also modifies the IS_ERR_OR_NULL function model. When freeing the pointer in this function, many double-free patterns have been reported. Without this change, these problems have not been seen, and we did not loose any other irrelevant defects.