Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Property fields/description not allowed ' in script configuration #284

Closed
neoc83 opened this issue Mar 12, 2020 · 5 comments
Closed

'Property fields/description not allowed ' in script configuration #284

neoc83 opened this issue Mar 12, 2020 · 5 comments
Labels

Comments

@neoc83
Copy link

neoc83 commented Mar 12, 2020

The validation comlains about 'Property fields/description not allowed ' in script configuration. See example code and screenshot below. Both the 'fields' and 'description' properties are allowed according to the HA documentation and also passes the validation in HA.

blink_light:
  alias: Blink light
  description: Blink the light that is passed as parameter 'light_entity_id'
  fields:
    light_entity_id:
      description: 'The entity_id of the light'
      example: 'light.light_1'
  sequence:
    - service: light.toggle
      data_template:
        entity_id: "{{ light_entity_id }}"
    - delay:
        seconds: 1
    - service: light.toggle
      data_template:
        entity_id: "{{ light_entity_id }}"

image

@neoc83 neoc83 added the yaml label Mar 12, 2020
@neoc83
Copy link
Author

neoc83 commented Mar 12, 2020

I tried to fix this myself in the schema but got stuck because I don't exactly know how to do it.

@zanix
Copy link

zanix commented Apr 30, 2020

You can add icon to the list of properties that are allowed but this extension says is not allowed.

@neoc83
Copy link
Author

neoc83 commented May 1, 2020

The problem is that the extension says that description and fields are not allowed as properties. However, in the documentation they are clearly described as optional properties: https://www.home-assistant.io/integrations/script/
And yes, for the icon property the same issue exists.

@GeorgeSG
Copy link
Contributor

GeorgeSG commented May 6, 2020

I have a PR open (#297) that adds the icon. I just updated it with description and fields too.

Unfortunately it's been open for more than a month, I hope @keesschollaart81 gets back to this :)

keesschollaart81 added a commit that referenced this issue May 8, 2020
@keesschollaart81 keesschollaart81 mentioned this issue May 8, 2020
@neoc83
Copy link
Author

neoc83 commented May 8, 2020

Thanks @GeorgeSG and @keesschollaart81. Works fine in VSC now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants