Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds external_url and internal_url #351

Closed
wants to merge 2 commits into from
Closed

Adds external_url and internal_url #351

wants to merge 2 commits into from

Conversation

theg00s3
Copy link

@theg00s3 theg00s3 commented Jun 5, 2020

Closes #344

@rasmusbe
Copy link

rasmusbe commented Jul 2, 2020

LGTM!

@frenck frenck mentioned this pull request Jul 9, 2020
Closed
@frenck
Copy link
Collaborator

frenck commented Jul 9, 2020

There is a duplicate of this PR in #355

This PR depends on #363, to provide these new options, to begin with.

@theg00s3 @frenck
Allows internal and external url to be a string or a null
9834329 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@ikifar2012
Copy link

Closed duplicate PR #355

@frenck frenck mentioned this pull request Jul 11, 2020
Merged
@frenck
Copy link
Collaborator

frenck commented Jul 11, 2020

I've also added it to #374
Not because I wanted to bypass you, but the structure is changing in that PR, which would made this PR a merge conflict.

@frenck
Copy link
Collaborator

frenck commented Jul 12, 2020

Replaced by #374

@frenck frenck closed this Jul 12, 2020
@keesschollaart81 keesschollaart81 mentioned this pull request Jul 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for external_url: and internal_url: found in HA 0.110.3
4 participants
@theg00s3 @rasmusbe @frenck @ikifar2012