-
-
Notifications
You must be signed in to change notification settings - Fork 57
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
antelle
committed
Dec 1, 2019
1 parent
4a7b57e
commit ac0315d
Showing
6 changed files
with
10 additions
and
7 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,7 +59,7 @@ var HeaderConst = { | |
|
||
var LastMinorVersions = { | ||
3: 1, | ||
4: 1 | ||
4: 0 | ||
}; | ||
|
||
/** | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac0315d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know where it is used, but the MaxFileVersionMinor should probably also be
0
.ac0315d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it's not used at all
ac0315d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @antelle,
Strongbox developer here. Kudos on this work.
I've just had an email from a KeeWeb user who is complaining that he can't open his KeeWeb database. This looks to be because the File Version is 4.1 which Strongbox is not expecting (it's expecting 4.0).
I can add support/accept this 4.1 version but I'm just wondering why it's 4.1 and what extra/other features 4.1 supports over 4.0? I think most other clients are serializing at 4.0.
Thanks!
-Mark
ac0315d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmcguill Hi! I think I made a file in some application writing it as 4.1, so I thought it was 4.1, or it was just a coding mistake, not sure how it ended up in being 4.1 here.
This was fixed in 2019 and now files are created correctly as v4.0:
But some users actually could have been stuck with 4.1, that's a good point, I'll add a check if a file has v4.1 and is created by KeeWeb, it will be saved as 4.0 to fix this.
ac0315d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next version will re-save them as v4.0
keeweb/keeweb@b2e69b6
ac0315d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thank you. I will also add some code to allow this and save as 4.0.
Cheers!