Skip to content

Commit

Permalink
fixed minor version for v4 files
Browse files Browse the repository at this point in the history
  • Loading branch information
antelle committed Dec 1, 2019
1 parent 4a7b57e commit ac0315d
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 7 deletions.
4 changes: 2 additions & 2 deletions dist/kdbxweb.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/kdbxweb.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/kdbxweb.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/format/kdbx-header.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ var HeaderConst = {

var LastMinorVersions = {
3: 1,
4: 1
4: 0
};

/**
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "kdbxweb",
"version": "1.5.6",
"version": "1.5.7",
"description": "Kdbx KeePass database reader for web",
"repository": {
"type": "git",
Expand Down
3 changes: 3 additions & 0 deletions release-notes.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
Release notes
-------------
##### v1.5.7 (2019-12-01)
`+` fixed minor version for v4 files

##### v1.5.6 (2019-10-26)
`+` generating missing ids while reading files

Expand Down

6 comments on commit ac0315d

@trxa
Copy link

@trxa trxa commented on ac0315d Dec 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know where it is used, but the MaxFileVersionMinor should probably also be 0.

@antelle
Copy link
Member

@antelle antelle commented on ac0315d Dec 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it's not used at all

@mmcguill
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @antelle,

Strongbox developer here. Kudos on this work.

I've just had an email from a KeeWeb user who is complaining that he can't open his KeeWeb database. This looks to be because the File Version is 4.1 which Strongbox is not expecting (it's expecting 4.0).

I can add support/accept this 4.1 version but I'm just wondering why it's 4.1 and what extra/other features 4.1 supports over 4.0? I think most other clients are serializing at 4.0.

Thanks!
-Mark

@antelle
Copy link
Member

@antelle antelle commented on ac0315d Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmcguill Hi! I think I made a file in some application writing it as 4.1, so I thought it was 4.1, or it was just a coding mistake, not sure how it ended up in being 4.1 here.
This was fixed in 2019 and now files are created correctly as v4.0:
Screen Shot 2020-04-07 at 16 47 55

But some users actually could have been stuck with 4.1, that's a good point, I'll add a check if a file has v4.1 and is created by KeeWeb, it will be saved as 4.0 to fix this.

@antelle
Copy link
Member

@antelle antelle commented on ac0315d Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next version will re-save them as v4.0
keeweb/keeweb@b2e69b6

@mmcguill
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you. I will also add some code to allow this and save as 4.0.
Cheers!

Please sign in to comment.