Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify workflow and specify node version #53

Merged
merged 9 commits into from
May 7, 2024

Conversation

HarlemSquirrel
Copy link
Contributor

@HarlemSquirrel HarlemSquirrel commented Apr 16, 2024

  • Verify with linters and by building the browser extensions on each push.
  • Add web-ext
  • Specify the same node version we're using with the main app.

@Aetherinox
Copy link

Aetherinox commented May 3, 2024

Is this one ready to go or are you still adding?

I'd try to see if we can bump prettier to v3 since that's what KeeWeb is running on now, then the configs can be used across the board.

I made a really nice config for ESLint, but there are still plugins not compatible with the latest version, so I have to wait.

@HarlemSquirrel
Copy link
Contributor Author

This is ready if it looks good to you

@HarlemSquirrel
Copy link
Contributor Author

I can try bumping prettier

@HarlemSquirrel HarlemSquirrel merged commit 281ed9f into keeweb:master May 7, 2024
5 checks passed
@HarlemSquirrel HarlemSquirrel deleted the add-verify branch May 7, 2024 03:19
@Aetherinox
Copy link

Aetherinox commented May 7, 2024

Prettier v3 die on you?

@HarlemSquirrel
Copy link
Contributor Author

Prettier v3 die on you?

Yeah, led me down dependency hell. Opened new PR to work on node 18 and hopefully prettier 3

@Aetherinox
Copy link

Trust me, already went through that with KeeWeb.

I lost a week of my life just fixing that mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants